fix(api): workflow run report (#2992)

Author: fsamin

engine/api/workflow/workflow_run_event.go

@@ -238,6 +238,9 @@ func sendVCSEventStatus(db gorp.SqlExecutor, store cache.Store, proj *sdk.Projec
 	//Send comment on pull request
 	for _, pr := range prs {
 		if pr.Head.Branch.DisplayID == nodeRun.VCSBranch && pr.Head.Branch.LatestCommit == nodeRun.VCSHash {
+			if nodeRun.Status != sdk.StatusFail.String() {
+				continue
+			}
 			report, err := nodeRun.Report()
 			if err != nil {
 				log.Error("sendVCSEventStatus> unable to compute node run report%v", err)

sdk/workflow_run.go

@@ -293,13 +293,17 @@ func (w *WorkflowNodeRunArtifact) GetPath() string {
 	return container
 }
 
-const workflowNodeRunReport = `CDS Report {{.WorkflowNodeName}}#{{.Number}}.{{.SubNumber}}
-{{range $s := .Stages}}
+const workflowNodeRunReport = `{{- if .Stages }} 
+CDS Report {{.WorkflowNodeName}}#{{.Number}}.{{.SubNumber}} {{ if eq .Status "Success" -}} ✔ {{ else }}{{ if eq .Status "Fail" -}} ✘ {{ else }}- {{ end }} {{ end }}
+{{- range $s := .Stages}}
+{{- if $s.RunJobs }}
 * {{$s.Name}}
 {{- range $j := $s.RunJobs}}
   * {{$j.Job.Action.Name}} {{ if eq $j.Status "Success" -}} ✔ {{ else }}{{ if eq $j.Status "Fail" -}} ✘ {{ else }}- {{ end }} {{ end }}
 {{- end}}
-{{end}}
+{{- end}}
+{{- end}}
+{{- end}}
 
 {{- if .Tests }} 
 {{- if gt .Tests.TotalKO 0}}

sdk/workflow_run_test.go

@@ -69,6 +69,9 @@ func TestWorkflowRunReport(t *testing.T) {
 			},
 		},
 	}
+	s, err := wfr.Report()
+	assert.NoError(t, err)
+	t.Log(s)
 
 	wfr = WorkflowNodeRun{
 		Stages: []Stage{
@@ -98,10 +101,24 @@ func TestWorkflowRunReport(t *testing.T) {
 				},
 			},
 		},
+		Tests:  nil,
+		Status: StatusSuccess.String(),
+	}
+
+	s, err = wfr.Report()
+	assert.NoError(t, err)
+	t.Log(s)
+
+	wfr = WorkflowNodeRun{
+		Stages: []Stage{
+			{
+				Name: "stage 1",
+			},
+		},
 		Tests: nil,
 	}
 
-	s, err := wfr.Report()
+	s, err = wfr.Report()
 	assert.NoError(t, err)
 	t.Log(s)
 }