Skip to content

Commit 0bc7a67

Browse files
authored
fix(api): compute workflow v3 preview (#6346)
1 parent 382bf78 commit 0bc7a67

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

engine/api/workflow.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,9 @@ func (api *API) getWorkflowHandler() service.Handler {
219219
vars := mux.Vars(r)
220220
key := vars["key"]
221221
name := vars["permWorkflowNameAdvanced"]
222+
if name == "" {
223+
name = vars["permWorkflowName"] // Useful for workflowv3 routes
224+
}
222225
withUsage := service.FormBool(r, "withUsage")
223226
withAudits := service.FormBool(r, "withAudits")
224227
withLabels := service.FormBool(r, "withLabels")

engine/api/workflow/dao.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,10 @@ func Load(ctx context.Context, db gorp.SqlExecutor, _ cache.Store, proj sdk.Proj
257257
ctx, end := telemetry.Span(ctx, "workflow.Load")
258258
defer end()
259259

260+
if name == "" {
261+
return nil, sdk.NewErrorFrom(sdk.ErrInvalidData, "invalid given workflow name")
262+
}
263+
260264
dao := opts.GetWorkflowDAO()
261265
dao.Filters.ProjectKey = proj.Key
262266
dao.Filters.WorkflowName = name

engine/api/workflow_run.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,9 @@ func (api *API) getWorkflowRunHandler() service.Handler {
266266
vars := mux.Vars(r)
267267
key := vars["key"]
268268
name := vars["permWorkflowNameAdvanced"]
269+
if name == "" {
270+
name = vars["permWorkflowName"] // Useful for workflowv3 routes
271+
}
269272
number, err := requestVarInt(r, "number")
270273
if err != nil {
271274
return err

0 commit comments

Comments
 (0)