feat(utils/validateResultSet): add warning for oversized result sets

This behaviour is generally undesirable and may lead to
excessive memory use or crashes.

Author: thelindat

src/database/rawExecute.ts

@@ -5,6 +5,7 @@ import { executeType, parseExecute } from '../utils/parseExecute';
 import { getPoolConnection } from './connection';
 import { setCallback } from '../utils/setCallback';
 import { performance } from 'perf_hooks';
+import validateResultSet from 'utils/validateResultSet';
 
 export const rawExecute = async (
   invokingResource: string,
@@ -60,6 +61,8 @@ export const rawExecute = async (
       } else if (startTime) {
         logQuery(invokingResource, query, performance.now() - startTime, values);
       }
+
+      validateResultSet(invokingResource, query, result);
     }
 
     if (!cb) return response.length === 1 ? response[0] : response;

src/database/rawQuery.ts

@@ -7,6 +7,7 @@ import type { QueryType } from '../types';
 import { getPoolConnection } from './connection';
 import { RowDataPacket } from 'mysql2';
 import { performance } from 'perf_hooks';
+import validateResultSet from 'utils/validateResultSet';
 
 export const rawQuery = async (
   type: QueryType,
@@ -43,6 +44,8 @@ export const rawQuery = async (
       logQuery(invokingResource, query, performance.now() - startTime, parameters);
     }
 
+    validateResultSet(invokingResource, query, result);
+
     if (!cb) return parseResponse(type, result);
 
     try {

src/utils/validateResultSet.ts

@@ -0,0 +1,22 @@
+import { OkPacket, ProcedureCallPacket, ResultSetHeader, RowDataPacket } from 'mysql2/promise';
+
+const oversizedResultSet = GetConvarInt('mysql_resultset_warning', 1000);
+
+export default function (
+  invokingResource: string,
+  query: string,
+  rows:
+    | OkPacket
+    | ResultSetHeader
+    | ResultSetHeader[]
+    | RowDataPacket[]
+    | RowDataPacket[][]
+    | OkPacket[]
+    | ProcedureCallPacket
+) {
+  const length = Array.isArray(rows) ? rows.length : 0;
+
+  if (length < oversizedResultSet) return;
+
+  console.warn(`${invokingResource} executed a query with an oversized result set (${length} results)!\n${query}`);
+}