refactor(db/startTransaction): add 30s timeout to transactions

Author: thelindat

src/database/startTransaction.ts

@@ -2,27 +2,41 @@ import { getPoolConnection } from './connection';
 import { logError } from '../logger';
 import { CFXCallback, CFXParameters } from '../types';
 import { parseArguments } from 'utils/parseArguments';
+import { PoolConnection } from 'mysql2/promise';
+
+async function runQuery(conn: PoolConnection | null, sql: string, values: CFXParameters) {
+  [sql, values] = parseArguments(sql, values);
+
+  if (!conn)
+    throw new Error(
+      `Query: ${sql}\n${JSON.stringify(values)}\nConnection used by transaction timed out after 30 seconds.`
+    );
+
+  const [rows] = await conn.query(sql, values);
+  return rows;
+}
 
 export const startTransaction = async (
   invokingResource: string,
   queries: (...args: any[]) => Promise<boolean>,
   cb?: CFXCallback,
   isPromise?: boolean
 ) => {
-  const conn = await getPoolConnection();
+  let conn: PoolConnection | null = await getPoolConnection();
+  let response: boolean | null = false;
 
   if (!conn) return;
 
-  let response = false;
+  setTimeout(() => (response = null), 30000);
 
   try {
     await conn.beginTransaction();
 
-    const commit = await queries(async (sql: string, values: CFXParameters) => {
-      [sql, values] = parseArguments(sql, values);
-      const [rows] = await conn.query(sql, values);
-      return rows;
-    });
+    const commit = await queries((sql: string, values: CFXParameters) =>
+      runQuery(response === null ? null : conn, sql, values)
+    );
+
+    if (response === null) throw new Error(`Transaction has timed out after 30 seconds.`);
 
     response = commit === false ? false : true;
     response ? conn.commit() : conn.rollback();
@@ -31,6 +45,7 @@ export const startTransaction = async (
     logError(invokingResource, cb, isPromise, err);
   } finally {
     conn.release();
+    conn = null;
   }
 
   return cb ? cb(response) : response;