Skip to content
This repository was archived by the owner on Apr 29, 2025. It is now read-only.

Commit 15884fb

Browse files
committed
refactor: error handling
Meant to push this before release. Ensures errors are handled as before, regardless of using exports or lib/mysql; for compatibility.
1 parent a709f67 commit 15884fb

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

fxmanifest.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ game 'common'
33

44
name 'oxmysql'
55
description 'Database wrapper for FiveM utilising node-mysql2 offering improved performance and security.'
6-
version '2.3.2'
6+
version '2.3.3'
77
url 'https://github.com/overextended/oxmysql'
88
author 'overextended'
99

lib/MySQL.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ local function await(fn, query, parameters)
7474
end
7575

7676
p:resolve(result)
77-
end, GetCurrentResourceName, false)
77+
end, GetCurrentResourceName, true)
7878
return Await(p)
7979
end
8080

@@ -86,7 +86,7 @@ setmetatable(MySQL, {
8686

8787
__call = function(_, query, parameters, cb)
8888
query, parameters, cb = safeArgs(query, parameters, cb, method == 'transaction')
89-
return oxmysql[method](nil, query, parameters, cb, GetCurrentResourceName, true)
89+
return oxmysql[method](nil, query, parameters, cb, GetCurrentResourceName, false)
9090
end,
9191

9292
__index = function(_, index)

src/database/rawExecute.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export const rawExecute = async (
7777
.catch((err) => {
7878
const error = `${invokingResource} was unable to execute a query!\n${err}\n${`${query}`}`;
7979

80-
if (cb && !throwError) cb(null, error);
81-
if (throwError || !cb) throw new Error(error);
80+
if (cb && throwError) return cb(null, error);
81+
throw new Error(error);
8282
});
8383
};

src/database/rawQuery.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const rawQuery = async (
3030
}).catch((err) => {
3131
const error = `${invokingResource} was unable to execute a query!\n${err.message}\n${`${query} ${JSON.stringify(parameters)}`}`
3232

33-
if (cb && !throwError) cb(null, error);
34-
if (throwError || !cb) throw new Error(error);
33+
if (cb && throwError) return cb(null, error);
34+
throw new Error(error);
3535
});
3636
};

0 commit comments

Comments
 (0)