fix: regression in UsedTimes calculation

aeneasr · ory-bot · commit b432e46f763d · 2025-10-24T16:14:56.000Z
GitOrigin-RevId: 4068e8604043f3ce0eb8f9c1f1f8e2ea49aa6725
diff --git a/persistence/sql/persister_oauth2.go b/persistence/sql/persister_oauth2.go
@@ -477,7 +477,7 @@ func (p *Persister) GetRefreshTokenSession(ctx context.Context, signature string
 		row.FirstUsedAt.Valid &&
 		row.FirstUsedAt.Time.Add(graceful.Period).After(time.Now()) &&
 		(graceful.Count == 0 || // no limit
-			(row.UsedTimes.Valid && row.UsedTimes.Int32 < graceful.Count)) {
+			(row.UsedTimes.Int32 < graceful.Count)) {
 		// We return the request as is, which indicates that the token is active (because we are in the grace period still).
 		return row.toRequest(ctx, session, p)
 	}

Original file line number	Diff line number	Diff line change
`@@ -477,7 +477,7 @@ func (p *Persister) GetRefreshTokenSession(ctx context.Context, signature string`
`477`	`477`	`row.FirstUsedAt.Valid &&`
`478`	`478`	`row.FirstUsedAt.Time.Add(graceful.Period).After(time.Now()) &&`
`479`	`479`	`(graceful.Count == 0 \|\| // no limit`
`480`		`- (row.UsedTimes.Valid && row.UsedTimes.Int32 < graceful.Count)) {`
	`480`	`+ (row.UsedTimes.Int32 < graceful.Count)) {`
`481`	`481`	`// We return the request as is, which indicates that the token is active (because we are in the grace period still).`
`482`	`482`	`return row.toRequest(ctx, session, p)`
`483`	`483`	`}`