Skip to content

Commit b372fd2

Browse files
authored
feat: add id parameter to create oauth2-client cli (#3725)
Fixes #3724
1 parent 017ebae commit b372fd2

File tree

2 files changed

+353
-1
lines changed

2 files changed

+353
-1
lines changed

cmd/cmd_create_client.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ const (
2121
flagClientAllowedCORSOrigin = "allowed-cors-origin"
2222
flagClientAudience = "audience"
2323
flagClientBackchannelLogoutCallback = "backchannel-logout-callback"
24+
flagClientId = "id"
2425
flagClientName = "name"
2526
flagClientClientURI = "client-uri"
2627
flagClientContact = "contact"
@@ -86,8 +87,11 @@ To encrypt an auto-generated OAuth2 Client Secret, use flags ` + "`--pgp-key`" +
8687
}
8788

8889
secret := flagx.MustGetString(cmd, flagClientSecret)
90+
cl := clientFromFlags(cmd)
91+
cl.ClientId = pointerx.Ptr(flagx.MustGetString(cmd, flagClientId))
92+
8993
//nolint:bodyclose
90-
client, _, err := m.OAuth2Api.CreateOAuth2Client(cmd.Context()).OAuth2Client(clientFromFlags(cmd)).Execute()
94+
client, _, err := m.OAuth2Api.CreateOAuth2Client(cmd.Context()).OAuth2Client(cl).Execute()
9195
if err != nil {
9296
return cmdx.PrintOpenAPIError(cmd, err)
9397
}
@@ -111,5 +115,6 @@ To encrypt an auto-generated OAuth2 Client Secret, use flags ` + "`--pgp-key`" +
111115
},
112116
}
113117
registerClientFlags(cmd.Flags())
118+
cmd.Flags().String(flagClientId, "", "Provide the client's id.")
114119
return cmd
115120
}

0 commit comments

Comments
 (0)