Test all features in check.sh.

Author: orium

.github/workflows/ci.yml

@@ -35,6 +35,7 @@ jobs:
 
       - name: Install cargo plugins
         run: |
+          cargo install cargo-hack
           cargo install cargo-rdme
           cargo install cargo-machete
           cargo install taplo-cli

Cargo.toml

@@ -35,7 +35,6 @@ serde_json = "1.0.145"
 static_assertions = "1.1.0"
 
 [features]
-fatal-warnings = []
 triomphe = ["dep:triomphe"]
 serde = ["dep:serde"]
 

README.md

@@ -42,7 +42,7 @@ archery = "<version>"
 
 `archery` defines a [`SharedPointer`](https://docs.rs/archery/latest/archery/shared_pointer/struct.SharedPointer.html)
 that receives the [kind of pointer](https://docs.rs/archery/latest/archery/shared_pointer/kind/trait.SharedPointerKind.html)
-as a type parameter.  This gives you a convenient and ergonomic way to abstract the pointer
+as a type parameter. This gives you a convenient and ergonomic way to abstract the pointer
 type away.
 
 ### Example
@@ -90,8 +90,8 @@ kind in [`SharedPointer`](https://docs.rs/archery/latest/archery/shared_pointer/
 
 ### Serialization
 
-We support serialization through [serde](https://crates.io/crates/serde).  To use it
-enable the `serde` feature.  To do so change the archery dependency in your `Cargo.toml` to
+We support serialization through [serde](https://crates.io/crates/serde). To use it
+enable the `serde` feature. To do so change the archery dependency in your `Cargo.toml` to
 
 ```toml
 [dependencies]
@@ -100,13 +100,13 @@ archery = { version = "<version>", features = ["serde"] }
 ## Limitations
 
 Currently it is not possible to have unsized types inside a
-[`SharedPointer`](https://docs.rs/archery/latest/archery/shared_pointer/struct.SharedPointer.html).  As a workaround you can put the
+[`SharedPointer`](https://docs.rs/archery/latest/archery/shared_pointer/struct.SharedPointer.html). As a workaround you can put the
 unsized type inside a [`Box`](https://doc.rust-lang.org/stable/alloc/boxed/struct.Box.html).
 
 ## Alternative approaches
 
 An alternative to the approach taken by `archery` is to use traits with associated types to encode
-type-level functions.  This has been suggested
+type-level functions. This has been suggested
 [multiple](https://github.com/orium/rpds/issues/7#issuecomment-362635901)
 [times](https://joshlf.com/post/2018/10/18/rust-higher-kinded-types-already/#comment-4160863400),
 but offers ugly ergonomics (see

benches/archery_shared_pointer_arc.rs

@@ -1,10 +1,7 @@
-#![cfg_attr(feature = "fatal-warnings", deny(warnings))]
-
 use archery::*;
-use std::ops::Deref;
-
 use criterion::{Criterion, criterion_group, criterion_main};
 use std::hint::black_box;
+use std::ops::Deref;
 
 fn archery_shared_pointer_arc_deref(c: &mut Criterion) {
     let limit = 200_000;

benches/archery_shared_pointer_arct.rs

@@ -1,10 +1,7 @@
-#![cfg_attr(feature = "fatal-warnings", deny(warnings))]
-
 use archery::*;
-use std::ops::Deref;
-
 use criterion::{Criterion, criterion_group, criterion_main};
 use std::hint::black_box;
+use std::ops::Deref;
 
 fn archery_shared_pointer_arct_deref(c: &mut Criterion) {
     let limit = 200_000;

benches/archery_shared_pointer_rc.rs

@@ -1,10 +1,7 @@
-#![cfg_attr(feature = "fatal-warnings", deny(warnings))]
-
 use archery::*;
-use std::ops::Deref;
-
 use criterion::{Criterion, criterion_group, criterion_main};
 use std::hint::black_box;
+use std::ops::Deref;
 
 fn archery_shared_pointer_rc_deref(c: &mut Criterion) {
     let limit = 200_000;

benches/std_arc.rs

@@ -1,10 +1,7 @@
-#![cfg_attr(feature = "fatal-warnings", deny(warnings))]
-
-use std::ops::Deref;
-use std::sync::Arc;
-
 use criterion::{Criterion, criterion_group, criterion_main};
 use std::hint::black_box;
+use std::ops::Deref;
+use std::sync::Arc;
 
 fn std_arc_deref(c: &mut Criterion) {
     let limit = 200_000;

benches/std_rc.rs

@@ -1,10 +1,7 @@
-#![cfg_attr(feature = "fatal-warnings", deny(warnings))]
-
-use std::ops::Deref;
-use std::rc::Rc;
-
 use criterion::{Criterion, criterion_group, criterion_main};
 use std::hint::black_box;
+use std::ops::Deref;
+use std::rc::Rc;
 
 fn std_rc_deref(c: &mut Criterion) {
     let limit = 200_000;

src/lib.rs

@@ -1,6 +1,5 @@
 #![no_std]
-#![cfg_attr(feature = "fatal-warnings", deny(warnings))]
-// Note: If you change this remember to update `README.md`.  To do so run `cargo rdme`.
+// Note: If you change this remember to update `README.md`. To do so run `cargo rdme`.
 //! `archery` is a rust library that offers a way to abstraction over
 //! [`Rc`](::alloc::rc::Rc) and
 //! [`Arc`](::alloc::sync::Arc) smart pointers.
@@ -31,7 +30,7 @@
 //!
 //! `archery` defines a [`SharedPointer`](crate::shared_pointer::SharedPointer)
 //! that receives the [kind of pointer](crate::shared_pointer::kind::SharedPointerKind)
-//! as a type parameter.  This gives you a convenient and ergonomic way to abstract the pointer
+//! as a type parameter. This gives you a convenient and ergonomic way to abstract the pointer
 //! type away.
 //!
 //! ## Example
@@ -95,8 +94,8 @@
 //!
 //! ## Serialization
 //!
-//! We support serialization through [serde](https://crates.io/crates/serde).  To use it
-//! enable the `serde` feature.  To do so change the archery dependency in your `Cargo.toml` to
+//! We support serialization through [serde](https://crates.io/crates/serde). To use it
+//! enable the `serde` feature. To do so change the archery dependency in your `Cargo.toml` to
 //!
 //! ```toml
 //! [dependencies]
@@ -105,13 +104,13 @@
 //! # Limitations
 //!
 //! Currently it is not possible to have unsized types inside a
-//! [`SharedPointer`](crate::shared_pointer::SharedPointer).  As a workaround you can put the
+//! [`SharedPointer`](crate::shared_pointer::SharedPointer). As a workaround you can put the
 //! unsized type inside a [`Box`](::alloc::boxed::Box).
 //!
 //! # Alternative approaches
 //!
 //! An alternative to the approach taken by `archery` is to use traits with associated types to encode
-//! type-level functions.  This has been suggested
+//! type-level functions. This has been suggested
 //! [multiple](https://github.com/orium/rpds/issues/7#issuecomment-362635901)
 //! [times](https://joshlf.com/post/2018/10/18/rust-higher-kinded-types-already/#comment-4160863400),
 //! but offers ugly ergonomics (see

tools/check.sh

@@ -20,20 +20,24 @@ assert_installed "cargo"
 
 trap on_failure ERR
 
+export RUSTFLAGS="-Dwarnings"
+
 function check_basic {
+    assert_installed "cargo-hack"
+
     echo 'Building:'
-    cargo build --features fatal-warnings --all-targets
+    cargo build --all-targets --all-features
     echo 'Testing:'
-    cargo test  --features fatal-warnings --all-targets
+    cargo hack test --each-feature --all-targets
     # Weirdly, the `cargo test ... --all-targets ...` above does not run the tests in the documentation, so we run the
     # doc tests like this.
     # See https://github.com/rust-lang/cargo/issues/6669.
     echo 'Testing doc:'
-    cargo test  --features fatal-warnings --doc
+    cargo test --doc --all-features
     echo 'Checking the benchmarks:'
-    cargo bench --features fatal-warnings -- --test
+    cargo bench --all-features -- --test
     echo 'Checking documentation:'
-    cargo doc   --features fatal-warnings --no-deps
+    cargo doc --no-deps --all-features
 
 	# Tests for memory safety and memory leaks with miri.
 	if [ -z "$MIRI_TOOLCHAIN" ]; then