ixed broken Country static data - had trialing empty string

oriches · oriches · commit f88cd76ec0f4 · 2021-03-19T10:29:55.000Z
diff --git a/src/Faker/Resources/Country.resx b/src/Faker/Resources/Country.resx
@@ -118,7 +118,7 @@
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
   <data name="Iso2LetterCodes" xml:space="preserve">
-    <value>AF;AX;AL;DZ;AS;AD;AO;AI;AQ;AG;AR;AM;AW;AU;AT;AZ;BH;BS;BD;BB;BY;BE;BZ;BJ;BM;BT;BO;BQ;BA;BW;BV;BR;IO;BN;BG;BF;BI;KH;CM;CA;CV;KY;CF;TD;CL;CN;CX;CC;CO;KM;CG;CD;CK;CR;CI;HR;CU;CW;CY;CZ;DK;DJ;DM;DO;EC;EG;SV;GQ;ER;EE;ET;FK;FO;FJ;FI;FR;GF;PF;TF;GA;GM;GE;DE;GH;GI;GR;GL;GD;GP;GU;GT;GG;GN;GW;GY;HT;HM;VA;HN;HK;HU;IS;IN;ID;IR;IQ;IE;IM;IL;IT;JM;JP;JE;JO;KZ;KE;KI;KP;KR;KW;KG;LA;LV;LB;LS;LR;LY;LI;LT;LU;MO;MK;MG;MW;MY;MV;ML;MT;MH;MQ;MR;MU;YT;MX;FM;MD;MC;MN;ME;MS;MA;MZ;MM;NA;NR;NP;NL;NC;NZ;NI;NE;NG;NU;NF;MP;NO;OM;PK;PW;PS;PA;PG;PY;PE;PH;PN;PL;PT;PR;QA;RE;RO;RU;RW;BL;SH;KN;LC;MF;PM;VC;WS;SM;ST;SA;SN;RS;SC;SL;SG;SX;SK;SI;SB;SO;ZA;GS;SS;ES;LK;SD;SR;SJ;SZ;SE;CH;SY;TW;TJ;TZ;TH;TL;TG;TK;TO;TT;TN;TR;TM;TC;TV;UG;UA;AE;GB;US;UM;UY;UZ;VU;VE;VN;VG;VI;WF;EH;YE;ZM;ZW;</value>
+    <value>AF;AX;AL;DZ;AS;AD;AO;AI;AQ;AG;AR;AM;AW;AU;AT;AZ;BH;BS;BD;BB;BY;BE;BZ;BJ;BM;BT;BO;BQ;BA;BW;BV;BR;IO;BN;BG;BF;BI;KH;CM;CA;CV;KY;CF;TD;CL;CN;CX;CC;CO;KM;CG;CD;CK;CR;CI;HR;CU;CW;CY;CZ;DK;DJ;DM;DO;EC;EG;SV;GQ;ER;EE;ET;FK;FO;FJ;FI;FR;GF;PF;TF;GA;GM;GE;DE;GH;GI;GR;GL;GD;GP;GU;GT;GG;GN;GW;GY;HT;HM;VA;HN;HK;HU;IS;IN;ID;IR;IQ;IE;IM;IL;IT;JM;JP;JE;JO;KZ;KE;KI;KP;KR;KW;KG;LA;LV;LB;LS;LR;LY;LI;LT;LU;MO;MK;MG;MW;MY;MV;ML;MT;MH;MQ;MR;MU;YT;MX;FM;MD;MC;MN;ME;MS;MA;MZ;MM;NA;NR;NP;NL;NC;NZ;NI;NE;NG;NU;NF;MP;NO;OM;PK;PW;PS;PA;PG;PY;PE;PH;PN;PL;PT;PR;QA;RE;RO;RU;RW;BL;SH;KN;LC;MF;PM;VC;WS;SM;ST;SA;SN;RS;SC;SL;SG;SX;SK;SI;SB;SO;ZA;GS;SS;ES;LK;SD;SR;SJ;SZ;SE;CH;SY;TW;TJ;TZ;TH;TL;TG;TK;TO;TT;TN;TR;TM;TC;TV;UG;UA;AE;GB;US;UM;UY;UZ;VU;VE;VN;VG;VI;WF;EH;YE;ZM;ZW</value>
   </data>
   <data name="Names" xml:space="preserve">
     <value>Afghanistan;Åland Islands;Albania;Algeria;American Samoa;Andorra;Angola;Anguilla;Antarctica;Antigua and Barbuda;Argentina;Armenia;Aruba;Australia;Austria;Azerbaijan;Bahrain;Bahamas;Bangladesh;Barbados;Belarus;Belgium;Belize;Benin;Bermuda;Bhutan;Bolivia, Plurinational State of;Bonaire, Sint Eustatius and Saba;Bosnia and Herzegovina;Botswana;Bouvet Island;Brazil;British Indian Ocean Territory;Brunei Darussalam;Bulgaria;Burkina Faso;Burundi;Cambodia;Cameroon;Canada;Cape Verde;Cayman Islands;Central African Republic;Chad;Chile;China;Christmas Island;Cocos (Keeling) Islands;Colombia;Comoros;Congo;Congo, the Democratic Republic of the;Cook Islands;Costa Rica;Côte d'Ivoire;Croatia;Cuba;Curaçao;Cyprus;Czech Republic;Denmark;Djibouti;Dominica;Dominican Republic;Ecuador;Egypt;El Salvador;Equatorial Guinea;Eritrea;Estonia;Ethiopia;Falkland Islands (Malvinas);Faroe Islands;Fiji;Finland;France;French Guiana;French Polynesia;French Southern Territories;Gabon;Gambia;Georgia;Germany;Ghana;Gibraltar;Greece;Greenland;Grenada;Guadeloupe;Guam;Guatemala;Guernsey;Guinea;Guinea-Bissau;Guyana;Haiti;Heard Island and McDonald Islands;Holy See (Vatican City State);Honduras;Hong Kong;Hungary;Iceland;India;Indonesia;Iran, Islamic Republic of;Iraq;Ireland;Isle of Man;Israel;Italy;Jamaica;Japan;Jersey;Jordan;Kazakhstan;Kenya;Kiribati;Korea, Democratic People's Republic of;Korea, Republic of;Kuwait;Kyrgyzstan;Lao People's Democratic Republic;Latvia;Lebanon;Lesotho;Liberia;Libya;Liechtenstein;Lithuania;Luxembourg;Macao;Macedonia, the Former Yugoslav Republic of;Madagascar;Malawi;Malaysia;Maldives;Mali;Malta;Marshall Islands;Martinique;Mauritania;Mauritius;Mayotte;Mexico;Micronesia, Federated States of;Moldova, Republic of;Monaco;Mongolia;Montenegro;Montserrat;Morocco;Mozambique;Myanmar;Namibia;Nauru;Nepal;Netherlands;New Caledonia;New Zealand;Nicaragua;Niger;Nigeria;Niue;Norfolk Island;Northern Mariana Islands;Norway;Oman;Pakistan;Palau;Palestine, State of;Panama;Papua New Guinea;Paraguay;Peru;Philippines;Pitcairn;Poland;Portugal;Puerto Rico;Qatar;Réunion;Romania;Russian Federation;Rwanda;Saint Barthélemy;Saint Helena, Ascension and Tristan da Cunha;Saint Kitts and Nevis;Saint Lucia;Saint Martin (French part);Saint Pierre and Miquelon;Saint Vincent and the Grenadines;Samoa;San Marino;Sao Tome and Principe;Saudi Arabia;Senegal;Serbia;Seychelles;Sierra Leone;Singapore;Sint Maarten (Dutch part);Slovakia;Slovenia;Solomon Islands;Somalia;South Africa;South Georgia and the South Sandwich Islands;South Sudan;Spain;Sri Lanka;Sudan;Suriname;Svalbard and Jan Mayen;Swaziland;Sweden;Switzerland;Syrian Arab Republic;Taiwan, Province of China;Tajikistan;Tanzania, United Republic of;Thailand;Timor-Leste;Togo;Tokelau;Tonga;Trinidad and Tobago;Tunisia;Turkey;Turkmenistan;Turks and Caicos Islands;Tuvalu;Uganda;Ukraine;United Arab Emirates;United Kingdom;United States;United States Minor Outlying Islands;Uruguay;Uzbekistan;Vanuatu;Venezuela, Bolivarian Republic of;Viet Nam;Virgin Islands, British;Virgin Islands, U.S.;Wallis and Futuna;Western Sahara;Yemen;Zambia;Zimbabwe</value>
diff --git a/tests/Faker.Tests/CountryFixture.cs b/tests/Faker.Tests/CountryFixture.cs
@@ -9,19 +9,25 @@ public class CountryFixture
         [Test]
         public void should_return_two_letter_country_code()
         {
-            var currency = Country.TwoLetterCode();
-            Console.WriteLine($@"TwoLetterCode=[{currency}]");
+            for (var i = 0; i < 20; i++)
+            {
+                var currency = Country.TwoLetterCode();
+                Console.WriteLine($@"Iteration=[{i}], TwoLetterCode=[{currency}]");
 
-            Assert.That(currency.Length, Is.EqualTo(2));
+                Assert.That(currency.Length, Is.EqualTo(2));
+            }
         }
 
         [Test]
         public void should_return_country_name()
         {
-            var name = Country.Name();
-            Console.WriteLine($@"Name=[{name}]");
+            for (var i = 0; i < 20; i++)
+            {
+                var name = Country.Name();
+                Console.WriteLine($@"Iteration=[{i}], Name=[{name}]");
 
-            Assert.That(name, Is.Not.Empty);
+                Assert.That(name, Is.Not.Empty);
+            }
         }
     }
 }
diff --git a/tests/Faker.Tests/CurrencyFixture.cs b/tests/Faker.Tests/CurrencyFixture.cs
@@ -9,19 +9,25 @@ public class CurrencyFixture
         [Test]
         public void should_return_three_letter_currency_code()
         {
-            var currency = Currency.ThreeLetterCode();
-            Console.WriteLine($@"ThreeLetterCode=[{currency}]");
+            for (var i = 0; i < 20; i++)
+            {
+                var currency = Currency.ThreeLetterCode();
+                Console.WriteLine($@"Iteration=[{i}], ThreeLetterCode=[{currency}]");
 
-            Assert.That(currency.Length, Is.EqualTo(3));
+                Assert.That(currency.Length, Is.EqualTo(3));
+            }
         }
 
         [Test]
         public void should_return_currency_name()
         {
-            var currency = Currency.Name();
-            Console.WriteLine($@"Name=[{currency}]");
+            for (var i = 0; i < 20; i++)
+            {
+                var currency = Currency.Name();
+                Console.WriteLine($@"Iteration=[{i}], Name=[{currency}]");
 
-            Assert.That(currency, Is.Not.Empty);
+                Assert.That(currency, Is.Not.Empty);
+            }
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,19 +9,25 @@ public class CountryFixture`
`9`	`9`	`[Test]`
`10`	`10`	`public void should_return_two_letter_country_code()`
`11`	`11`	`{`
`12`		`- var currency = Country.TwoLetterCode();`
`13`		`- Console.WriteLine($@"TwoLetterCode=[{currency}]");`
	`12`	`+ for (var i = 0; i < 20; i++)`
	`13`	`+ {`
	`14`	`+ var currency = Country.TwoLetterCode();`
	`15`	`+ Console.WriteLine($@"Iteration=[{i}], TwoLetterCode=[{currency}]");`
`14`	`16`
`15`		`- Assert.That(currency.Length, Is.EqualTo(2));`
	`17`	`+ Assert.That(currency.Length, Is.EqualTo(2));`
	`18`	`+ }`
`16`	`19`	`}`
`17`	`20`
`18`	`21`	`[Test]`
`19`	`22`	`public void should_return_country_name()`
`20`	`23`	`{`
`21`		`- var name = Country.Name();`
`22`		`- Console.WriteLine($@"Name=[{name}]");`
	`24`	`+ for (var i = 0; i < 20; i++)`
	`25`	`+ {`
	`26`	`+ var name = Country.Name();`
	`27`	`+ Console.WriteLine($@"Iteration=[{i}], Name=[{name}]");`
`23`	`28`
`24`		`- Assert.That(name, Is.Not.Empty);`
	`29`	`+ Assert.That(name, Is.Not.Empty);`
	`30`	`+ }`
`25`	`31`	`}`
`26`	`32`	`}`
`27`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,19 +9,25 @@ public class CurrencyFixture`
`9`	`9`	`[Test]`
`10`	`10`	`public void should_return_three_letter_currency_code()`
`11`	`11`	`{`
`12`		`- var currency = Currency.ThreeLetterCode();`
`13`		`- Console.WriteLine($@"ThreeLetterCode=[{currency}]");`
	`12`	`+ for (var i = 0; i < 20; i++)`
	`13`	`+ {`
	`14`	`+ var currency = Currency.ThreeLetterCode();`
	`15`	`+ Console.WriteLine($@"Iteration=[{i}], ThreeLetterCode=[{currency}]");`
`14`	`16`
`15`		`- Assert.That(currency.Length, Is.EqualTo(3));`
	`17`	`+ Assert.That(currency.Length, Is.EqualTo(3));`
	`18`	`+ }`
`16`	`19`	`}`
`17`	`20`
`18`	`21`	`[Test]`
`19`	`22`	`public void should_return_currency_name()`
`20`	`23`	`{`
`21`		`- var currency = Currency.Name();`
`22`		`- Console.WriteLine($@"Name=[{currency}]");`
	`24`	`+ for (var i = 0; i < 20; i++)`
	`25`	`+ {`
	`26`	`+ var currency = Currency.Name();`
	`27`	`+ Console.WriteLine($@"Iteration=[{i}], Name=[{currency}]");`
`23`	`28`
`24`		`- Assert.That(currency, Is.Not.Empty);`
	`29`	`+ Assert.That(currency, Is.Not.Empty);`
	`30`	`+ }`
`25`	`31`	`}`
`26`	`32`	`}`
`27`	`33`	`}`