Add sort to linkChannels output before diff check

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

alpha/template/semver/semver.go

@@ -283,8 +283,6 @@ func (sv *semverTemplate) generateChannels(semverChannels *bundleVersions) []dec
 }
 
 func (sv *semverTemplate) linkChannels(unlinkedChannels map[string]*declcfg.Channel, harvestedVersions *bundleVersions) []declcfg.Channel {
-	channels := []declcfg.Channel{}
-
 	// bundle --> version lookup
 	bundleVersions := make(map[string]semver.Version)
 	for _, vs := range *harvestedVersions {
@@ -295,6 +293,7 @@ func (sv *semverTemplate) linkChannels(unlinkedChannels map[string]*declcfg.Chan
 		}
 	}
 
+	channels := make([]declcfg.Channel, 0, len(unlinkedChannels))
 	for _, channel := range unlinkedChannels {
 		entries := &channel.Entries
 		sort.Slice(*entries, func(i, j int) bool {

alpha/template/semver/semver_test.go

@@ -1,7 +1,9 @@
 package semver
 
 import (
+	sortcmp "cmp"
 	"fmt"
+	"slices"
 	"strings"
 	"testing"
 
@@ -251,7 +253,11 @@ func TestLinkChannels(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			sv := &semverTemplate{pkg: "a", GenerateMajorChannels: tt.generateMajorChannels, GenerateMinorChannels: tt.generateMinorChannels}
-			diff := cmp.Diff(tt.out, sv.linkChannels(tt.unlinkedChannels, &channelOperatorVersions))
+			actual := sv.linkChannels(tt.unlinkedChannels, &channelOperatorVersions)
+			slices.SortFunc(actual, func(a, b declcfg.Channel) int {
+				return sortcmp.Compare(a.Name, b.Name)
+			})
+			diff := cmp.Diff(tt.out, actual)
 			if diff != "" {
 				t.Errorf("unexpected channel diff (-expected +received):\n%s", diff)
 			}