Replace the actual production image with a sample image path and apply minor changes

Signed-off-by: jubittajohn <[email protected]>

Author: jubittajohn

internal/resolution/resolver_test.go

@@ -22,13 +22,13 @@ func TestOperatorResolver(t *testing.T) {
 
 	testEntityCache := map[deppy.Identifier]input.Entity{"operatorhub/prometheus/0.37.0": *input.NewEntity(
 		"operatorhub/prometheus/0.37.0", map[string]string{
-			"olm.bundle.path": `"quay.io/operatorhubio/prometheus@sha256:3e281e587de3d03011440685fc4fb782672beab044c1ebadc42788ce05a21c35"`,
+			"olm.bundle.path": `"foo.io/bar/baz"`,
 			"olm.channel":     "{\"channelName\":\"beta\",\"priority\":0,\"replaces\":\"prometheusoperator.0.32.0\"}",
 			"olm.gvk":         "[{\"group\":\"monitoring.coreos.com\",\"kind\":\"Alertmanager\",\"version\":\"v1\"}, {\"group\":\"monitoring.coreos.com\",\"kind\":\"Prometheus\",\"version\":\"v1\"}]",
 			"olm.package":     "{\"packageName\":\"prometheus\",\"version\":\"0.37.0\"}",
 		}),
 		"operatorhub/prometheus/0.47.0": *input.NewEntity("operatorhub/prometheus/0.47.0", map[string]string{
-			"olm.bundle.path": `"quay.io/operatorhubio/prometheus@sha256:5b04c49d8d3eff6a338b56ec90bdf491d501fe301c9cdfb740e5bff6769a21ed"`,
+			"olm.bundle.path": `"foo.io/bar/baz"`,
 			"olm.channel":     "{\"channelName\":\"beta\",\"priority\":0,\"replaces\":\"prometheusoperator.0.37.0\"}",
 			"olm.gvk":         "[{\"group\":\"monitoring.coreos.com\",\"kind\":\"Alertmanager\",\"version\":\"v1\"}, {\"group\":\"monitoring.coreos.com\",\"kind\":\"Prometheus\",\"version\":\"v1alpha1\"}]",
 			"olm.package":     "{\"packageName\":\"prometheus\",\"version\":\"0.47.0\"}",
@@ -63,54 +63,53 @@ func TestOperatorResolver(t *testing.T) {
 	}
 
 	for _, tt := range []struct {
-		Name              string
-		Client            client.Client
-		EntitySource      input.EntitySource
-		SelectedVariables []deppy.Identifier
-		ExpectedError     error
+		name                      string
+		client                    client.Client
+		entitySource              input.EntitySource
+		expectedSelectedVariables []deppy.Identifier
+		expectedError             error
 	}{
 		{
-			Name:         "should resolve the packages described by the available Operator resources",
-			Client:       FakeClient(testResource...),
-			EntitySource: testEntitySource,
-			SelectedVariables: []deppy.Identifier{"operatorhub/packageA/2.0.0",
+			name:         "should resolve the packages described by the available Operator resources",
+			client:       FakeClient(testResource...),
+			entitySource: testEntitySource,
+			expectedSelectedVariables: []deppy.Identifier{
+				"operatorhub/packageA/2.0.0",
 				"operatorhub/prometheus/0.47.0",
 				"required package packageA",
 				"required package prometheus"},
-			ExpectedError: nil,
+			expectedError: nil,
 		},
 		{
-			Name:              "should not return an error if there are no Operator resources",
-			Client:            FakeClient(),
-			EntitySource:      testEntitySource,
-			SelectedVariables: []deppy.Identifier{},
-			ExpectedError:     nil,
+			name:                      "should not return an error if there are no Operator resources",
+			client:                    FakeClient(),
+			entitySource:              testEntitySource,
+			expectedSelectedVariables: []deppy.Identifier{},
+			expectedError:             nil,
 		},
 		{
-			Name:          "should return an error if the entity source throws an error",
-			Client:        FakeClient(testResource...),
-			EntitySource:  FailEntitySource{},
-			ExpectedError: fmt.Errorf("error calling filter in entity source"),
+			name:          "should return an error if the entity source throws an error",
+			client:        FakeClient(testResource...),
+			entitySource:  FailEntitySource{},
+			expectedError: fmt.Errorf("error calling filter in entity source"),
 		},
 		{
-			Name:          "should return an error if the client throws an error",
-			Client:        NewFailClientWithError(fmt.Errorf("something bad happened")),
-			EntitySource:  testEntitySource,
-			ExpectedError: fmt.Errorf("something bad happened"),
+			name:          "should return an error if the client throws an error",
+			client:        NewFailClientWithError(fmt.Errorf("something bad happened")),
+			entitySource:  testEntitySource,
+			expectedError: fmt.Errorf("something bad happened"),
 		},
 	} {
-		t.Run(tt.Name, func(t *testing.T) {
-			client := tt.Client
-			entitySource := tt.EntitySource
-			resolver := resolution.NewOperatorResolver(client, entitySource)
+		t.Run(tt.name, func(t *testing.T) {
+			resolver := resolution.NewOperatorResolver(tt.client, tt.entitySource)
 			solution, err := resolver.Resolve(context.Background())
 
-			if tt.ExpectedError != nil {
-				assert.Equal(t, err, tt.ExpectedError)
+			if tt.expectedError != nil {
+				assert.Equal(t, tt.expectedError, err)
 				assert.Nil(t, solution)
 			} else {
-				assert.Len(t, solution.SelectedVariables(), len(tt.SelectedVariables))
-				for _, identifier := range tt.SelectedVariables {
+				assert.Len(t, solution.SelectedVariables(), len(tt.expectedSelectedVariables))
+				for _, identifier := range tt.expectedSelectedVariables {
 					assert.True(t, solution.IsSelected(identifier))
 				}
 				assert.NoError(t, err)