Skip to content

Commit 051cb1c

Browse files
author
Mikalai Radchuk
committed
Fixes kind cluster cleanup in e2e make target
Currently we have `kind-cluster-cleanup` as a dependency in `kind-cluster` target. Since `make` only builds a target once this means that `e2e` target performs cleanup before creating a new cluster and skips cleanup at the end leaving cluster hanging around. With this change, `make e2e` will be failing on cluster creation, if a cluster with the same name already exists, but the failure message will clearly indicate the issue. Signed-off-by: Mikalai Radchuk <[email protected]>
1 parent 3c55b14 commit 051cb1c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ e2e: run kind-load-test-artifacts test-e2e kind-cluster-cleanup ## Run e2e test
108108
kind-load: $(KIND) ## Loads the currently constructed image onto the cluster
109109
$(KIND) load docker-image $(IMG) --name $(KIND_CLUSTER_NAME)
110110

111-
kind-cluster: $(KIND) kind-cluster-cleanup ## Standup a kind cluster
111+
kind-cluster: $(KIND) ## Standup a kind cluster
112112
$(KIND) create cluster --name ${KIND_CLUSTER_NAME}
113113
$(KIND) export kubeconfig --name ${KIND_CLUSTER_NAME}
114114

0 commit comments

Comments
 (0)