Bug fix for scaled_float in encodePoint method (#18952) (#18968)

* Fix scaled float bug



* Update changelog



* Update changelog



* Add clamps



---------


(cherry picked from commit 35a91c1)

Signed-off-by: Prudhvi Godithi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: opensearch-trigger-bot[bot]

CHANGELOG.md

@@ -119,6 +119,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Fix socks5 user password settings for Azure repo ([#18904](https://github.com/opensearch-project/OpenSearch/pull/18904))
 - Fix gRPC transport SETTING_GRPC_MAX_MSG_SIZE setting not exposed to users ([#18910](https://github.com/opensearch-project/OpenSearch/pull/18910))
 - Reset isPipelineResolved to false to resolve the system ingest pipeline again. ([#18911](https://github.com/opensearch-project/OpenSearch/pull/18911))
+- Bug fix for `scaled_float` in `encodePoint` method ([#18952](https://github.com/opensearch-project/OpenSearch/pull/18952))
 
 ### Security
 

modules/mapper-extras/src/main/java/org/opensearch/index/mapper/ScaledFloatFieldMapper.java

@@ -219,8 +219,7 @@ public byte[] encodePoint(Number value) {
 
         @Override
         public byte[] encodePoint(Object value, boolean roundUp) {
-            double doubleValue = parse(value);
-            long scaledValue = Math.round(scale(doubleValue));
+            long scaledValue = Math.round(scale(value));
             if (roundUp) {
                 if (scaledValue < Long.MAX_VALUE) {
                     scaledValue = scaledValue + 1;
@@ -230,7 +229,9 @@ public byte[] encodePoint(Object value, boolean roundUp) {
                     scaledValue = scaledValue - 1;
                 }
             }
-            return encodePoint(scaledValue);
+            byte[] point = new byte[Long.BYTES];
+            LongPoint.encodeDimension(scaledValue, point, 0);
+            return point;
         }
 
         public double getScalingFactor() {

modules/mapper-extras/src/test/java/org/opensearch/index/mapper/ScaledFloatFieldMapperTests.java

@@ -33,6 +33,7 @@
 package org.opensearch.index.mapper;
 
 import org.apache.lucene.document.Document;
+import org.apache.lucene.document.LongPoint;
 import org.apache.lucene.document.SortedNumericDocValuesField;
 import org.apache.lucene.document.StoredField;
 import org.apache.lucene.index.DirectoryReader;
@@ -473,4 +474,19 @@ public void testRejectIndexOptions() {
         assertThat(e.getMessage(), containsString("Failed to parse mapping [_doc]: Field [scaling_factor] is required"));
         assertWarnings("Parameter [index_options] has no effect on type [scaled_float] and will be removed in future");
     }
+
+    public void testScaledFloatEncodePoint() {
+        double scalingFactor = 100.0;
+        ScaledFloatFieldMapper.ScaledFloatFieldType fieldType = new ScaledFloatFieldMapper.ScaledFloatFieldType(
+            "test_field",
+            scalingFactor
+        );
+        double originalValue = 10.5;
+        byte[] encodedRoundUp = fieldType.encodePoint(originalValue, true);
+        byte[] encodedRoundDown = fieldType.encodePoint(originalValue, false);
+        long decodedUp = LongPoint.decodeDimension(encodedRoundUp, 0);
+        long decodedDown = LongPoint.decodeDimension(encodedRoundDown, 0);
+        assertEquals(1051, decodedUp); // 10.5 scaled = 1050, then +1 = 1051 (represents 10.51)
+        assertEquals(1049, decodedDown); // 10.5 scaled = 1050, then -1 = 1049 (represents 10.49)
+    }
 }

release-notes/opensearch.release-notes-3.2.0.md

@@ -111,4 +111,5 @@ Compatible with OpenSearch and OpenSearch Dashboards version 3.2.0
 * Close IndexFieldDataService asynchronously ([#18888](https://github.com/opensearch-project/OpenSearch/pull/18888))
 * Fix query string regex queries incorrectly swallowing TooComplexToDeterminizeException ([#18883](https://github.com/opensearch-project/OpenSearch/pull/18883))
 * Fix socks5 user password settings for Azure repo ([#18904](https://github.com/opensearch-project/OpenSearch/pull/18904))
-* Reset isPipelineResolved to false to resolve the system ingest pipeline again. ([#18911](https://github.com/opensearch-project/OpenSearch/pull/18911))
+* Reset isPipelineResolved to false to resolve the system ingest pipeline again. ([#18911](https://github.com/opensearch-project/OpenSearch/pull/18911))
+* Bug fix for `scaled_float` in `encodePoint` method ([#18952](https://github.com/opensearch-project/OpenSearch/pull/18952))