fix: 7019 - "donate" is now accessible; no webview for most URLs (#7061)

* fix: 7019 - "donate" is now accessible; no webview for most URLs

Impacted files:
* `url_preference_tile.dart`: now using launchURL instead of webviews
* `user_preferences_faq.dart`: now using launchURL instead of webviews

* new business rules

* added comment

* reformated because of a sad MF format behavior of the editor

Author: monsieurtanuki

packages/smooth_app/lib/pages/preferences_v2/preferences_page.dart

@@ -9,6 +9,7 @@ import 'package:smooth_app/data_models/user_management_provider.dart';
 import 'package:smooth_app/generic_lib/widgets/app_bars/logged_in/logged_in_app_bar.dart';
 import 'package:smooth_app/generic_lib/widgets/app_bars/logged_out/logged_out_app_bar.dart';
 import 'package:smooth_app/helpers/analytics_helper.dart';
+import 'package:smooth_app/helpers/launch_url_helper.dart';
 import 'package:smooth_app/l10n/app_localizations.dart';
 import 'package:smooth_app/pages/hunger_games/question_page.dart';
 import 'package:smooth_app/pages/preferences/user_preferences_page.dart';
@@ -243,7 +244,9 @@ class PreferencesPage extends StatelessWidget {
       leading: const icons.Donate(),
       title: appLocalizations.preferences_support_title,
       subtitleText: appLocalizations.preferences_support_subtitle,
-      url: appLocalizations.donate_url,
+      // the donate page includes javascript, not well accepted by webviews
+      url: 'using onTap instead',
+      onTap: () async => LaunchUrlHelper.launchURL(appLocalizations.donate_url),
     );
   }
 

packages/smooth_app/lib/pages/preferences_v2/tiles/url_preference_tile.dart

@@ -13,6 +13,7 @@ class UrlPreferenceTile extends PreferenceTile {
     super.icon,
     super.subtitleText,
     super.key,
+    super.onTap,
   }) : assert(url.isNotEmpty);
 
   final String url;
@@ -31,8 +32,9 @@ class UrlPreferenceTile extends PreferenceTile {
         size: 16.0,
         color: context.lightTheme() ? theme.primaryColor : Colors.white,
       ),
-      onTap: () async =>
-          LaunchUrlHelper.launchURLInWebViewOrBrowser(context, url),
+      onTap:
+          onTap ??
+          () async => LaunchUrlHelper.launchURLInWebViewOrBrowser(context, url),
     );
   }
 }