Skip to content

Commit 073c529

Browse files
fix: 7019 - "donate" is now accessible; no webview for most URLs (#7061)
* fix: 7019 - "donate" is now accessible; no webview for most URLs Impacted files: * `url_preference_tile.dart`: now using launchURL instead of webviews * `user_preferences_faq.dart`: now using launchURL instead of webviews * new business rules * added comment * reformated because of a sad MF format behavior of the editor
1 parent 7e139f1 commit 073c529

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

packages/smooth_app/lib/pages/preferences_v2/preferences_page.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import 'package:smooth_app/data_models/user_management_provider.dart';
99
import 'package:smooth_app/generic_lib/widgets/app_bars/logged_in/logged_in_app_bar.dart';
1010
import 'package:smooth_app/generic_lib/widgets/app_bars/logged_out/logged_out_app_bar.dart';
1111
import 'package:smooth_app/helpers/analytics_helper.dart';
12+
import 'package:smooth_app/helpers/launch_url_helper.dart';
1213
import 'package:smooth_app/l10n/app_localizations.dart';
1314
import 'package:smooth_app/pages/hunger_games/question_page.dart';
1415
import 'package:smooth_app/pages/preferences/user_preferences_page.dart';
@@ -243,7 +244,9 @@ class PreferencesPage extends StatelessWidget {
243244
leading: const icons.Donate(),
244245
title: appLocalizations.preferences_support_title,
245246
subtitleText: appLocalizations.preferences_support_subtitle,
246-
url: appLocalizations.donate_url,
247+
// the donate page includes javascript, not well accepted by webviews
248+
url: 'using onTap instead',
249+
onTap: () async => LaunchUrlHelper.launchURL(appLocalizations.donate_url),
247250
);
248251
}
249252

packages/smooth_app/lib/pages/preferences_v2/tiles/url_preference_tile.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ class UrlPreferenceTile extends PreferenceTile {
1313
super.icon,
1414
super.subtitleText,
1515
super.key,
16+
super.onTap,
1617
}) : assert(url.isNotEmpty);
1718

1819
final String url;
@@ -31,8 +32,9 @@ class UrlPreferenceTile extends PreferenceTile {
3132
size: 16.0,
3233
color: context.lightTheme() ? theme.primaryColor : Colors.white,
3334
),
34-
onTap: () async =>
35-
LaunchUrlHelper.launchURLInWebViewOrBrowser(context, url),
35+
onTap:
36+
onTap ??
37+
() async => LaunchUrlHelper.launchURLInWebViewOrBrowser(context, url),
3638
);
3739
}
3840
}

0 commit comments

Comments
 (0)