Skip to content

Commit b976f27

Browse files
fix: Update actions to remove check skip tests (feast-dev#5275)
Signed-off-by: Francisco Javier Arceo <[email protected]>
1 parent 5f46279 commit b976f27

File tree

8 files changed

+8
-66
lines changed

8 files changed

+8
-66
lines changed

.github/workflows/java_pr.yml

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,12 @@ permissions:
1111
pull-requests: read
1212

1313
jobs:
14-
check_skip_tests:
15-
uses: ./.github/workflows/check_skip_tests.yml
16-
with:
17-
head-sha: ${{ github.event.pull_request.head.sha }}
18-
excluded-dirs: 'docs/**,tests/**,examples/**'
19-
2014
lint-java:
2115
# when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
2216
if:
2317
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
2418
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
25-
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
19+
github.repository == 'feast-dev/feast'
2620
runs-on: ubuntu-latest
2721
steps:
2822
- uses: actions/checkout@v4
@@ -41,7 +35,7 @@ jobs:
4135
if:
4236
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
4337
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
44-
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
38+
github.repository == 'feast-dev/feast'
4539
runs-on: ubuntu-latest
4640
needs: lint-java
4741
steps:
@@ -119,7 +113,7 @@ jobs:
119113
if:
120114
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
121115
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
122-
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
116+
github.repository == 'feast-dev/feast'
123117
runs-on: ubuntu-latest
124118
needs: unit-test-java
125119
env:

.github/workflows/operator-e2e-integration-tests.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,12 @@ on:
1414
- 'infra/**'
1515

1616
jobs:
17-
check_skip_tests:
18-
uses: ./.github/workflows/check_skip_tests.yml
19-
with:
20-
head-sha: ${{ github.event.pull_request.head.sha }}
21-
excluded-dirs: 'docs/**,tests/**,examples/**'
22-
2317
operator-e2e-tests:
2418
timeout-minutes: 40
2519
if:
2620
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
2721
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
28-
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
22+
github.repository == 'feast-dev/feast'
2923
runs-on: ubuntu-latest
3024

3125
services:

.github/workflows/operator_pr.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,7 @@ name: operator-pr
22

33
on: [pull_request]
44
jobs:
5-
check_skip_tests:
6-
uses: ./.github/workflows/check_skip_tests.yml
7-
with:
8-
head-sha: ${{ github.event.pull_request.head.sha }}
9-
excluded-dirs: 'docs/**,tests/**,examples/**'
10-
115
operator-test:
12-
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
136
runs-on: ubuntu-latest
147
steps:
158
- uses: actions/checkout@v4

.github/workflows/pr_integration_tests.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,12 @@ permissions:
1616
pull-requests: read
1717

1818
jobs:
19-
check_skip_tests:
20-
uses: ./.github/workflows/check_skip_tests.yml
21-
with:
22-
head-sha: ${{ github.event.pull_request.head.sha }}
23-
excluded-dirs: 'docs/**,tests/**,examples/**'
24-
2519
integration-test-python:
2620
# when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
2721
if:
2822
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
2923
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
30-
github.repository == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
24+
github.repository == 'feast-dev/feast'
3125
runs-on: ${{ matrix.os }}
3226
strategy:
3327
fail-fast: false

.github/workflows/pr_local_integration_tests.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,11 @@ on:
99
- labeled
1010

1111
jobs:
12-
check_skip_tests:
13-
uses: ./.github/workflows/check_skip_tests.yml
14-
with:
15-
head-sha: ${{ github.event.pull_request.head.sha }}
16-
excluded-dirs: 'docs/**,tests/**,examples/**'
17-
1812
integration-test-python-local:
1913
if:
2014
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
2115
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
22-
github.event.pull_request.base.repo.full_name == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
16+
github.event.pull_request.base.repo.full_name == 'feast-dev/feast'
2317
runs-on: ${{ matrix.os }}
2418
strategy:
2519
fail-fast: false

.github/workflows/pr_remote_rbac_integration_tests.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,11 @@ on:
99
- labeled
1010

1111
jobs:
12-
check_skip_tests:
13-
uses: ./.github/workflows/check_skip_tests.yml
14-
with:
15-
head-sha: ${{ github.event.pull_request.head.sha }}
16-
excluded-dirs: 'docs/**,tests/**,examples/**'
17-
1812
remote-rbac-integration-tests-python:
1913
if:
2014
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
2115
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) &&
22-
github.event.pull_request.base.repo.full_name == 'feast-dev/feast' && needs.check_skip_tests.outputs.skip_tests == 'false'
16+
github.event.pull_request.base.repo.full_name == 'feast-dev/feast'
2317
runs-on: ${{ matrix.os }}
2418
strategy:
2519
fail-fast: false

.github/workflows/smoke_tests.yml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,7 @@ on:
44
pull_request:
55

66
jobs:
7-
check_skip_tests:
8-
uses: ./.github/workflows/check_skip_tests.yml
9-
with:
10-
head-sha: ${{ github.event.pull_request.head.sha }}
11-
excluded-dirs: 'docs/**,tests/**,examples/**'
12-
13-
unit-test-python:
14-
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
7+
smoke-test-python:
158
runs-on: ${{ matrix.os }}
169
strategy:
1710
fail-fast: false

.github/workflows/unit_tests.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,7 @@ on:
44
pull_request:
55

66
jobs:
7-
check_skip_tests:
8-
runs-on: ubuntu-latest
9-
outputs:
10-
skip_tests: ${{ steps.check.outputs.skip_tests }}
11-
steps:
12-
- uses: actions/checkout@v4
13-
- id: check
14-
uses: ./.github/actions/check-skip-tests
15-
with:
16-
head-sha: ${{ github.event.pull_request.head.sha || github.sha }}
17-
187
unit-test-python:
19-
needs: [check_skip_tests]
20-
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
218
runs-on: ${{ matrix.os }}
229
strategy:
2310
fail-fast: false
@@ -55,7 +42,6 @@ jobs:
5542
run: uv cache prune --ci
5643

5744
unit-test-ui:
58-
if: ${{ needs.check_skip_tests.outputs.skip_tests == 'false' }}
5945
runs-on: ubuntu-latest
6046
env:
6147
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

0 commit comments

Comments
 (0)