Merge pull request #323 from opencredit/alpha

Merge 1.4.1 release from alpha.

Author: brichards

badgeos.php

@@ -4,7 +4,7 @@
 * Plugin URI: http://www.badgeos.org/
 * Description: BadgeOS lets your site’s users complete tasks and earn badges that recognize their achievement.  Define achievements and choose from a range of options that determine when they're complete.  Badges are Mozilla Open Badges (OBI) compatible through integration with the “Open Credit” API by Credly, the free web service for issuing, earning and sharing badges for lifelong achievement.
 * Author: LearningTimes
-* Version: 1.4.0
+* Version: 1.4.1
 * Author URI: https://credly.com/
 * License: GNU AGPL
 */
@@ -32,7 +32,7 @@ class BadgeOS {
 	 *
 	 * @var string
 	 */
-	public static $version = '1.4.0';
+	public static $version = '1.4.1';
 
 	function __construct() {
 		// Define plugin constants

includes/achievement-functions.php

@@ -830,10 +830,12 @@ function badgeos_maybe_update_achievement_type( $data = '', $post_args = '' ) {
  * @return bool             True if name has changed, otherwise false.
  */
 function badgeos_achievement_type_changed( $post_args = array() ) {
+	$original_post = isset( $post_args['ID'] ) ? get_post( $post_args['ID'] ) : null;
 	return (
 		'achievement-type' === $post_args['post_type']
-		&& $post_args['ID']
-		&& get_post( $post_args['ID'] )->post_title !== $post_args['post_title']
+		&& is_object( $original_post )
+		&& ! empty( $original_post->post_name )
+		&& $original_post->post_title !== $post_args['post_title']
 	);
 }
 
@@ -847,6 +849,12 @@ function badgeos_achievement_type_changed( $post_args = array() ) {
  * @return string                New achievement type.
  */
 function badgeos_update_achievement_types( $original_type = '', $new_type = '' ) {
+
+	// Sanity check to prevent alterating core posts
+	if ( ! $original_type || in_array( $original_type, array( 'post', 'page', 'attachment', 'revision', 'nav_menu_item' ) ) ) {
+		return $new_type;
+	}
+
 	badgeos_update_achievements_achievement_types( $original_type, $new_type );
 	badgeos_update_p2p_achievement_types( $original_type, $new_type );
 	badgeos_update_earned_meta_achievement_types( $original_type, $new_type );

readme.txt

@@ -4,7 +4,7 @@ Donate link: http://badgeos.org/contribute/donate/
 Tags: badge, badges, openbadges, learningtimes, credly, OBI, mozilla, open badges, achievement, award, reward, engagement, submission, nomination, API, open credit, credit
 Requires at least: 3.6
 Tested up to: 3.9.1
-Stable tag: 1.4.0
+Stable tag: 1.4.1
 License: GNU AGPLv3
 License URI: http://www.gnu.org/licenses/agpl-3.0.html
 
@@ -119,11 +119,11 @@ BadgeOS is extremely powerful and infinitely extensible. Check out some of the o
 * Optional notification emails inform you when people on your site have made submissions or nominated peers.
 * Submission Notification Settings: Specify an unlimited number of email addresses for submission admin notifications.
 * Notifications for: new submissions, new comments, and submission status changes
+* Filter Submissions to only show those from members of specific BuddyPress Groups (requires plugins: [BuddyPress](http://wordpress.org/extend/plugins/buddypress/ "BuddyPress") and [BadgeOS Community Add-on](http://wordpress.org/extend/plugins/badgeos-community-add-on/ "BadgeOS Community Add-on"))
 
 
 = Extensibility and BadgeOS Add-ons =
 
-
 * BadgeOS is designed to be a true operating system for turning any WordPress site into an engagement management application.
 * BadgeOS offers a growing catalog of [Add-ons](http://badgeos.org/add-ons/ "BadgeOS Add-ons") to the plugin that enhance core functionality with specialized functions.
 * Built with expandability in mind to allow virtually anything to trigger and recognize achievement.
@@ -220,6 +220,9 @@ Thanks for asking!  Please do share back code modifications or enhancements you
 
 == Changelog ==
 
+= 1.4.1 =
+* Fixed: Eliminated a critical bug that could cause all posts to be migrated to a brand new achievement type on publish.
+
 = 1.4.0 =
 * Added: BadgeOS Shortcode Embedder – Easily add any shortcode to any content area with a few clicks.
 * Added: BadgeOS Shortcode registration API – Easily add support for new BadgeOS-related shortcodes and modify existing shortcodes with automatic support for the BOS Shortcode Embedder and help page.
@@ -355,6 +358,9 @@ Thanks for asking!  Please do share back code modifications or enhancements you
 
 == Upgrade Notice ==
 
+= 1.4.1 =
+* Fixed: Eliminated a critical bug that could cause all posts to be migrated to a brand new achievement type on publish.
+
 = 1.4.0 =
 * Added: BadgeOS Shortcode Embedder – Easily add any shortcode to any content area with a few clicks.
 * Added: BadgeOS Shortcode registration API – Easily add support for new BadgeOS-related shortcodes and modify existing shortcodes with automatic support for the BOS Shortcode Embedder and help page.