Skip to content

Commit 5074db9

Browse files
ChrsMarkLiudmila Molkova
andauthored
Rename system.network.connections to system.network.connection.count (#2425)
Signed-off-by: ChrsMark <[email protected]> Co-authored-by: Liudmila Molkova <[email protected]>
1 parent 35b3e06 commit 5074db9

File tree

5 files changed

+50
-6
lines changed

5 files changed

+50
-6
lines changed
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Use this changelog template to create an entry for release notes.
2+
#
3+
# If your change doesn't affect end users you should instead start
4+
# your pull request title with [chore] or use the "Skip Changelog" label.
5+
6+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
7+
change_type: breaking
8+
9+
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
10+
component: system
11+
12+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
13+
note: Changes system.network.connections to system.network.connection.count
14+
15+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
16+
# The values here must be integers.
17+
issues: [1800]
18+
19+
# (Optional) One or more lines of additional information to render under the primary note.
20+
# These lines will be padded with 2 spaces and then inserted directly into the document.
21+
# Use pipe (|) for multiline entries.
22+
subtext:

docs/system/system-metrics.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ Resource attributes related to a host, SHOULD be reported under the `host.*` nam
5353
- [Metric: `system.network.packets`](#metric-systemnetworkpackets)
5454
- [Metric: `system.network.errors`](#metric-systemnetworkerrors)
5555
- [Metric: `system.network.io`](#metric-systemnetworkio)
56-
- [Metric: `system.network.connections`](#metric-systemnetworkconnections)
56+
- [Metric: `system.network.connection.count`](#metric-systemnetworkconnectioncount)
5757
- [Aggregate system process metrics](#aggregate-system-process-metrics)
5858
- [Metric: `system.process.count`](#metric-systemprocesscount)
5959
- [Metric: `system.process.created`](#metric-systemprocesscreated)
@@ -1026,11 +1026,11 @@ This metric is [recommended][MetricRecommended].
10261026
<!-- END AUTOGENERATED TEXT -->
10271027
<!-- endsemconv -->
10281028

1029-
### Metric: `system.network.connections`
1029+
### Metric: `system.network.connection.count`
10301030

10311031
This metric is [recommended][MetricRecommended].
10321032

1033-
<!-- semconv metric.system.network.connections -->
1033+
<!-- semconv metric.system.network.connection.count -->
10341034
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
10351035
<!-- see templates/registry/markdown/snippet.md.j2 -->
10361036
<!-- prettier-ignore-start -->
@@ -1039,7 +1039,7 @@ This metric is [recommended][MetricRecommended].
10391039

10401040
| Name | Instrument Type | Unit (UCUM) | Description | Stability | Entity Associations |
10411041
| -------- | --------------- | ----------- | -------------- | --------- | ------ |
1042-
| `system.network.connections` | UpDownCounter | `{connection}` | | ![Development](https://img.shields.io/badge/-development-blue) | `host` |
1042+
| `system.network.connection.count` | UpDownCounter | `{connection}` | | ![Development](https://img.shields.io/badge/-development-blue) | `host` |
10431043

10441044
| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
10451045
|---|---|---|---|---|---|
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
groups:
2+
- id: metric.system.network.connections
3+
type: metric
4+
metric_name: system.network.connections
5+
stability: development
6+
deprecated:
7+
reason: renamed
8+
renamed_to: system.network.connection.count
9+
brief: "Deprecated, use `system.network.connection.count` instead"
10+
instrument: updowncounter
11+
unit: "{connection}"
12+
attributes:
13+
- ref: network.interface.name
14+
- ref: network.connection.state
15+
- ref: network.transport
16+
entity_associations:
17+
- host

model/system/metrics.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,9 +399,9 @@ groups:
399399
entity_associations:
400400
- host
401401

402-
- id: metric.system.network.connections
402+
- id: metric.system.network.connection.count
403403
type: metric
404-
metric_name: system.network.connections
404+
metric_name: system.network.connection.count
405405
stability: development
406406
brief: ""
407407
instrument: updowncounter

schema-next.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@ file_format: 1.1.0
22
schema_url: https://opentelemetry.io/schemas/next
33
versions:
44
next:
5+
metrics:
6+
changes:
7+
# https://github.com/open-telemetry/semantic-conventions/issues/1800
8+
- rename_metrics:
9+
system.network.connections: system.network.connection.count
510
attributes:
611
changes:
712
# https://github.com/open-telemetry/semantic-conventions/pull/1698

0 commit comments

Comments
 (0)