Skip to content

Commit 8d8b107

Browse files
committed
Fix test and add changelog entry for #3536
1 parent 6c796b6 commit 8d8b107

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## Unreleased
99

10+
- Log stacktrace on `UNKNOWN` status OTLP export error
11+
([#3536](https://github.com/open-telemetry/opentelemetry-python/pull/3536))
1012
- Fix OTLPExporterMixin shutdown timeout period
1113
([#3524](https://github.com/open-telemetry/opentelemetry-python/pull/3524))
1214

exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_metrics_exporter.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -453,8 +453,8 @@ def test_unavailable_delay(self, mock_sleep, mock_expo):
453453
"opentelemetry.exporter.otlp.proto.grpc.exporter._create_exp_backoff_generator"
454454
)
455455
@patch("opentelemetry.exporter.otlp.proto.grpc.exporter.sleep")
456-
@patch("opentelemetry.exporter.otlp.proto.grpc.exporter.logger")
457-
def test_unknown_logs(self, mock_sleep, mock_expo, mock_logger):
456+
@patch("opentelemetry.exporter.otlp.proto.grpc.exporter.logger.error")
457+
def test_unknown_logs(self, mock_logger_error, mock_sleep, mock_expo):
458458

459459
mock_expo.configure_mock(**{"return_value": [1]})
460460

@@ -465,11 +465,11 @@ def test_unknown_logs(self, mock_sleep, mock_expo, mock_logger):
465465
self.exporter.export(self.metrics["sum_int"]),
466466
MetricExportResult.FAILURE,
467467
)
468-
mock_sleep.assert_called_with(1)
469-
mock_logger.error.assert_called_with(
468+
mock_sleep.assert_not_called()
469+
mock_logger_error.assert_called_with(
470470
"Failed to export %s to %s, error code: %s",
471471
"metrics",
472-
"TODO",
472+
"localhost:4317",
473473
StatusCode.UNKNOWN,
474474
exc_info=True,
475475
)

0 commit comments

Comments
 (0)