Skip to content

Commit 99c477f

Browse files
humivoMrAlias
andauthored
Fixed typo for default service name in Jaeger Exporter (#1797)
* Fix typo in jaeger exporter * Update changelog * Add PR number to changelog * Move entry in changelog to Fixed Co-authored-by: Tyler Yahn <[email protected]>
1 parent 95fd8f5 commit 99c477f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
4646
- The Jaeger exporter now correctly records Span event's names using the `"event"` key for a tag.
4747
Additionally, this tag is overridden, as specified in the OTel specification, if the event contains an attribute with that key. (#1768)
4848
- Zipkin Exporter: Ensure mapping between OTel and Zipkin span data complies with the specification. (#1688)
49+
- Fixed typo for default service name in Jaeger Exporter. (#1797)
4950

5051
### Changed
5152

exporters/trace/jaeger/jaeger.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ func process(res *resource.Resource, defaultServiceName string) *gen.Process {
490490
// If no service.name is contained in a Span's Resource,
491491
// that field MUST be populated from the default Resource.
492492
if serviceName.Value.AsString() == "" {
493-
serviceName = semconv.ServiceVersionKey.String(defaultServiceName)
493+
serviceName = semconv.ServiceNameKey.String(defaultServiceName)
494494
}
495495
process.ServiceName = serviceName.Value.AsString()
496496

0 commit comments

Comments
 (0)