Update description string construction

nholbrook · nholbrook · commit b10f67d4012b · 2020-07-08T07:50:32.000-06:00
diff --git a/sdk/src/trace/samplers/probability.cc b/sdk/src/trace/samplers/probability.cc
@@ -29,11 +29,9 @@ namespace trace_api = opentelemetry::trace;
 ProbabilitySampler::ProbabilitySampler(double probability)
 : threshold_(CalculateThreshold(probability))
 {
-    char buffer[30];
     if (probability > 1.0) probability = 1.0;
     if (probability < 0.0) probability = 0.0;
-    sprintf(buffer, "ProbabilitySampler{%.6f}", probability);
-    sampler_description_ = std::string(buffer);
+    sampler_description_ = "ProbabilitySampler{" + std::to_string(probability) + "}";
   }
 
 SamplingResult ProbabilitySampler::ShouldSample(

Original file line number	Diff line number	Diff line change
`@@ -29,11 +29,9 @@ namespace trace_api = opentelemetry::trace;`
`29`	`29`	`ProbabilitySampler::ProbabilitySampler(double probability)`
`30`	`30`	`: threshold_(CalculateThreshold(probability))`
`31`	`31`	`{`
`32`		`- char buffer[30];`
`33`	`32`	`if (probability > 1.0) probability = 1.0;`
`34`	`33`	`if (probability < 0.0) probability = 0.0;`
`35`		`- sprintf(buffer, "ProbabilitySampler{%.6f}", probability);`
`36`		`- sampler_description_ = std::string(buffer);`
	`34`	`+ sampler_description_ = "ProbabilitySampler{" + std::to_string(probability) + "}";`
`37`	`35`	`}`
`38`	`36`
`39`	`37`	`SamplingResult ProbabilitySampler::ShouldSample(`