Skip to content

Commit f680426

Browse files
authored
[chore][ci] port check-codeowners workflow from contrib (#13908)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR ports the `check-codeowners` workflow from the `opentelemetry-collector-contrib` repository. On this side, the command referenced in the workflow is `make generate-codeowners` instead of `make gencodeowners` as is in the contrib version. In the `Makefile`, I added the `-skipgithub` to avoid giving an error like below when the members run it. ```sh 2025/09/25 22:52:36 set the environment variable `GITHUB_TOKEN` to a PAT token to authenticate ``` I ran `gengithub`, which also produced some changes in issue templates. Like the PR #13898, I also removed the `make install-tools` from this workflow. The idea to port this workflow here came from the PR open-telemetry/opentelemetry-collector-contrib#42999 discussion in Slack. --------- Signed-off-by: Paulo Dias <[email protected]>
1 parent 05d0d76 commit f680426

File tree

6 files changed

+72
-4
lines changed

6 files changed

+72
-4
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
cmd/builder/ @open-telemetry/collector-approvers
2222
cmd/mdatagen/ @open-telemetry/collector-approvers @dmitryax
2323
cmd/mdatagen/internal/sampleconnector/ @open-telemetry/collector-approvers
24+
cmd/mdatagen/internal/samplefactoryreceiver/ @open-telemetry/collector-approvers @dmitryax
2425
cmd/mdatagen/internal/sampleprocessor/ @open-telemetry/collector-approvers
2526
cmd/mdatagen/internal/samplereceiver/ @open-telemetry/collector-approvers @dmitryax
2627
cmd/mdatagen/internal/samplescraper/ @open-telemetry/collector-approvers @dmitryax

.github/ISSUE_TEMPLATE/bug_report.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ body:
2020
# Start components list
2121
- cmd/builder
2222
- cmd/mdatagen
23+
- cmd/mdatagen/internal/sampleconnector
24+
- cmd/mdatagen/internal/samplefactoryreceiver
2325
- cmd/mdatagen/internal/sampleprocessor
2426
- cmd/mdatagen/internal/samplereceiver
2527
- cmd/mdatagen/internal/samplescraper
@@ -35,8 +37,8 @@ body:
3537
- docs/rfcs
3638
- exporter/debug
3739
- exporter/exporterhelper
40+
- exporter/exporterhelper/internal/queuebatch
3841
- exporter/exporterhelper/xexporterhelper
39-
- exporter/exporterqueue
4042
- exporter/nop
4143
- exporter/otlp
4244
- exporter/otlphttp

.github/ISSUE_TEMPLATE/feature_request.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ body:
1414
# Start components list
1515
- cmd/builder
1616
- cmd/mdatagen
17+
- cmd/mdatagen/internal/sampleconnector
18+
- cmd/mdatagen/internal/samplefactoryreceiver
1719
- cmd/mdatagen/internal/sampleprocessor
1820
- cmd/mdatagen/internal/samplereceiver
1921
- cmd/mdatagen/internal/samplescraper
@@ -29,8 +31,8 @@ body:
2931
- docs/rfcs
3032
- exporter/debug
3133
- exporter/exporterhelper
34+
- exporter/exporterhelper/internal/queuebatch
3235
- exporter/exporterhelper/xexporterhelper
33-
- exporter/exporterqueue
3436
- exporter/nop
3537
- exporter/otlp
3638
- exporter/otlphttp

.github/ISSUE_TEMPLATE/other.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ body:
1313
# Start components list
1414
- cmd/builder
1515
- cmd/mdatagen
16+
- cmd/mdatagen/internal/sampleconnector
17+
- cmd/mdatagen/internal/samplefactoryreceiver
1618
- cmd/mdatagen/internal/sampleprocessor
1719
- cmd/mdatagen/internal/samplereceiver
1820
- cmd/mdatagen/internal/samplescraper
@@ -28,8 +30,8 @@ body:
2830
- docs/rfcs
2931
- exporter/debug
3032
- exporter/exporterhelper
33+
- exporter/exporterhelper/internal/queuebatch
3134
- exporter/exporterhelper/xexporterhelper
32-
- exporter/exporterqueue
3335
- exporter/nop
3436
- exporter/otlp
3537
- exporter/otlphttp
Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
name: codeowners
2+
on:
3+
push:
4+
branches: [main]
5+
paths:
6+
- ".github/CODEOWNERS"
7+
- "**/metadata.yaml"
8+
tags:
9+
- "v[0-9]+.[0-9]+.[0-9]+*"
10+
pull_request_target:
11+
paths:
12+
- ".github/CODEOWNERS"
13+
- "**/metadata.yaml"
14+
types:
15+
- opened
16+
- synchronize
17+
- edited
18+
- reopened
19+
env:
20+
# Make sure to exit early if cache segment download times out after 2 minutes.
21+
# We limit cache download as a whole to 5 minutes.
22+
SEGMENT_DOWNLOAD_TIMEOUT_MINS: 2
23+
24+
# Do not cancel this workflow on main. See https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/16616
25+
concurrency:
26+
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
27+
cancel-in-progress: true
28+
29+
permissions: read-all
30+
31+
jobs:
32+
check-codeowners:
33+
timeout-minutes: 30
34+
runs-on: ubuntu-24.04
35+
if: ${{ github.actor != 'dependabot[bot]' && github.repository == 'open-telemetry/opentelemetry-collector' }}
36+
steps:
37+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
38+
39+
- uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6
40+
id: go-setup
41+
with:
42+
go-version: oldstable
43+
cache-dependency-path: "**/*.sum"
44+
45+
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
46+
with:
47+
ref: ${{github.event.pull_request.head.ref}}
48+
repository: ${{github.event.pull_request.head.repo.full_name}}
49+
path: pr
50+
51+
- uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2.1.4
52+
id: otelbot-token
53+
with:
54+
app-id: ${{ vars.OTELBOT_APP_ID }}
55+
private-key: ${{ secrets.OTELBOT_PRIVATE_KEY }}
56+
57+
- name: Gen CODEOWNERS
58+
run: |
59+
cd pr
60+
GITHUB_TOKEN=${{ steps.otelbot-token.outputs.token }} ../.tools/githubgen --default-codeowner "open-telemetry/collector-approvers" codeowners
61+
git diff -s --exit-code || (echo 'Generated code is out of date, please run "make generate-codeowners" or apply this diff and commit the changes in this PR.' && git diff && exit 1)

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ generate-gh-issue-templates: $(GITHUBGEN)
467467

468468
.PHONY: generate-codeowners
469469
generate-codeowners: $(GITHUBGEN)
470-
$(GITHUBGEN) --default-codeowner "open-telemetry/collector-approvers" codeowners
470+
$(GITHUBGEN) --default-codeowner "open-telemetry/collector-approvers" -skipgithub codeowners
471471

472472
.PHONY: gengithub
473473
gengithub: $(GITHUBGEN) generate-codeowners generate-gh-issue-templates

0 commit comments

Comments
 (0)