fixing lint errors

Signed-off-by: Andreas Gkizas <[email protected]>

Author: gizas

receiver/otlpreceiver/internal/errors/errors.go

@@ -39,7 +39,8 @@ func GetClientDisconnectMessage(err error) string {
 }
 
 func GetStatusFromError(err error) error {
-	s, ok := status.FromError(err)
+	var s *status.Status
+	_, ok := status.FromError(err)
 	if !ok {
 		// Default to a retryable error
 		// https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md#failures

receiver/otlpreceiver/otlp_test.go

@@ -1208,7 +1208,7 @@ func (esc *errOrSinkConsumer) Reset() {
 func (esc *errOrSinkConsumer) checkData(t *testing.T, data any, dataLen int) {
 	switch data.(type) {
 	case ptrace.Traces:
-		allTraces := esc.TracesSink.AllTraces()
+		allTraces := esc.AllTraces()
 		require.Len(t, allTraces, dataLen)
 		if dataLen > 0 {
 			require.Equal(t, allTraces[0], data)

receiver/receiverhelper/internal/errors.go

@@ -1,7 +1,7 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
-package internal
+package internal // import "go.opentelemetry.io/collector/receiver/receiverhelper/internal"
 
 import "errors"
 

receiver/receiverhelper/obsreport_test.go

@@ -60,7 +60,7 @@ func TestReceiveTraceDataOp(t *testing.T) {
 		}
 
 		spans := tt.SpanRecorder.Ended()
-		require.Equal(t, len(params), len(spans))
+		require.Len(t, params, len(spans))
 
 		var acceptedSpans, refusedSpans int
 		for i, span := range spans {
@@ -126,7 +126,7 @@ func TestReceiveLogsOp(t *testing.T) {
 		}
 
 		spans := tt.SpanRecorder.Ended()
-		require.Equal(t, len(params), len(spans))
+		require.Len(t, params, len(spans))
 
 		var acceptedLogRecords, refusedLogRecords int
 		for i, span := range spans {
@@ -191,7 +191,7 @@ func TestReceiveMetricsOp(t *testing.T) {
 		}
 
 		spans := tt.SpanRecorder.Ended()
-		require.Equal(t, len(params), len(spans))
+		require.Len(t, params, len(spans))
 
 		var acceptedMetricPoints, refusedMetricPoints int
 		for i, span := range spans {
@@ -261,7 +261,7 @@ func TestReceiveWithLongLivedCtx(t *testing.T) {
 	}
 
 	spans := tt.SpanRecorder.Ended()
-	require.Equal(t, len(params), len(spans))
+	require.Len(t, params, len(spans))
 
 	for i, span := range spans {
 		assert.False(t, span.Parent().IsValid())