[chore]: enable len and empty rules from testifylint (#11021)

#### Description

Testifylint is a linter that provides best practices with the use of
testify.

This PR enables
[len](https://github.com/Antonboom/testifylint?tab=readme-ov-file#len)
and
[empty](https://github.com/Antonboom/testifylint?tab=readme-ov-file#empty)
rules from [testifylint](https://github.com/Antonboom/testifylint)

It also adds testifylint as tool to use with a make command

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yml

@@ -125,14 +125,12 @@ linters-settings:
     # TODO: enable all rules
     disable:
       - compares
-      - empty
       - error-is-as
       - error-nil
       - expected-actual
       - float-compare
       - formatter
       - go-require
-      - len
       - negative-positive
       - nil-compare
       - require-error

Makefile

@@ -56,6 +56,10 @@ gotest-with-cover:
 	@$(MAKE) for-all-target TARGET="test-with-cover"
 	$(GOCMD) tool covdata textfmt -i=./coverage/unit -o ./coverage.txt
 
+.PHONY: gotestifylint-fix
+gotestifylint-fix:
+	$(MAKE) for-all-target TARGET="testifylint-fix"
+
 .PHONY: goporto
 goporto: $(PORTO)
 	$(PORTO) -w --include-internal --skip-dirs "^cmd/mdatagen/third_party$$" ./

Makefile.Common

@@ -36,6 +36,9 @@ MULTIMOD     := $(TOOLS_BIN_DIR)/multimod
 PORTO        := $(TOOLS_BIN_DIR)/porto
 SEMCONVGEN   := $(TOOLS_BIN_DIR)/semconvgen
 SEMCONVKIT   := $(TOOLS_BIN_DIR)/semconvkit
+TESTIFYLINT  := $(TOOLS_BIN_DIR)/testifylint
+
+TESTIFYLINT_OPT?= --enable-all --disable=compares,error-is-as,error-nil,expected-actual,float-compare,formatter,go-require,negative-positive,nil-compare,require-error
 
 .PHONY: install-tools
 install-tools: $(TOOLS_BIN_NAMES)
@@ -88,3 +91,9 @@ impi: $(IMPI)
 .PHONY: moddownload
 moddownload:
 	$(GOCMD) mod download
+
+.PHONY: testifylint-fix
+testifylint-fix:$(TESTIFYLINT)
+	@echo "running $(TESTIFYLINT)"
+	@$(TESTIFYLINT) $(TESTIFYLINT_OPT) -fix ./...
+

cmd/builder/internal/builder/config_test.go

@@ -171,10 +171,10 @@ func TestNewBuiltinConfig(t *testing.T) {
 	// Unlike the config initialized in NewDefaultConfig(), we expect
 	// the builtin default to be practically useful, so there must be
 	// a set of modules present.
-	assert.NotZero(t, len(cfg.Receivers))
-	assert.NotZero(t, len(cfg.Exporters))
-	assert.NotZero(t, len(cfg.Extensions))
-	assert.NotZero(t, len(cfg.Processors))
+	assert.NotEmpty(t, cfg.Receivers)
+	assert.NotEmpty(t, cfg.Exporters)
+	assert.NotEmpty(t, cfg.Extensions)
+	assert.NotEmpty(t, cfg.Processors)
 }
 
 func TestSkipGoValidation(t *testing.T) {

connector/connectorprofiles/profiles_router_test.go

@@ -120,8 +120,8 @@ func TestProfilessRouterConsumer(t *testing.T) {
 	assert.Len(t, rcs, 2)
 	assert.ElementsMatch(t, []component.ID{fooID, barID}, rcs)
 
-	assert.Len(t, foo.AllProfiles(), 0)
-	assert.Len(t, bar.AllProfiles(), 0)
+	assert.Empty(t, foo.AllProfiles())
+	assert.Empty(t, bar.AllProfiles())
 
 	both, err := r.Consumer(fooID, barID)
 	assert.NotNil(t, both)

connector/forwardconnector/forward_test.go

@@ -57,7 +57,7 @@ func TestForward(t *testing.T) {
 	assert.NoError(t, metricsToMetrics.Shutdown(ctx))
 	assert.NoError(t, logsToLogs.Shutdown(ctx))
 
-	assert.Equal(t, 1, len(tracesSink.AllTraces()))
-	assert.Equal(t, 2, len(metricsSink.AllMetrics()))
-	assert.Equal(t, 3, len(logsSink.AllLogs()))
+	assert.Len(t, tracesSink.AllTraces(), 1)
+	assert.Len(t, metricsSink.AllMetrics(), 2)
+	assert.Len(t, logsSink.AllLogs(), 3)
 }

connector/logs_router_test.go

@@ -119,8 +119,8 @@ func TestLogsRouterConsumers(t *testing.T) {
 	assert.Len(t, rcs, 2)
 	assert.ElementsMatch(t, []component.ID{fooID, barID}, rcs)
 
-	assert.Len(t, foo.AllLogs(), 0)
-	assert.Len(t, bar.AllLogs(), 0)
+	assert.Empty(t, foo.AllLogs())
+	assert.Empty(t, bar.AllLogs())
 
 	both, err := r.Consumer(fooID, barID)
 	assert.NotNil(t, both)

connector/metrics_router_test.go

@@ -119,8 +119,8 @@ func TestMetricsRouterConsumers(t *testing.T) {
 	assert.Len(t, rcs, 2)
 	assert.ElementsMatch(t, []component.ID{fooID, barID}, rcs)
 
-	assert.Len(t, foo.AllMetrics(), 0)
-	assert.Len(t, bar.AllMetrics(), 0)
+	assert.Empty(t, foo.AllMetrics())
+	assert.Empty(t, bar.AllMetrics())
 
 	both, err := r.Consumer(fooID, barID)
 	assert.NotNil(t, both)

connector/traces_router_test.go

@@ -119,8 +119,8 @@ func TestTracesRouterConsumer(t *testing.T) {
 	assert.Len(t, rcs, 2)
 	assert.ElementsMatch(t, []component.ID{fooID, barID}, rcs)
 
-	assert.Len(t, foo.AllTraces(), 0)
-	assert.Len(t, bar.AllTraces(), 0)
+	assert.Empty(t, foo.AllTraces())
+	assert.Empty(t, bar.AllTraces())
 
 	both, err := r.Consumer(fooID, barID)
 	assert.NotNil(t, both)

consumer/consumertest/sink_test.go

@@ -28,7 +28,7 @@ func TestTracesSink(t *testing.T) {
 	assert.Equal(t, want, sink.AllTraces())
 	assert.Equal(t, len(want), sink.SpanCount())
 	sink.Reset()
-	assert.Equal(t, 0, len(sink.AllTraces()))
+	assert.Empty(t, sink.AllTraces())
 	assert.Equal(t, 0, sink.SpanCount())
 }
 
@@ -43,7 +43,7 @@ func TestMetricsSink(t *testing.T) {
 	assert.Equal(t, want, sink.AllMetrics())
 	assert.Equal(t, 2*len(want), sink.DataPointCount())
 	sink.Reset()
-	assert.Equal(t, 0, len(sink.AllMetrics()))
+	assert.Empty(t, sink.AllMetrics())
 	assert.Equal(t, 0, sink.DataPointCount())
 }
 
@@ -58,7 +58,7 @@ func TestLogsSink(t *testing.T) {
 	assert.Equal(t, want, sink.AllLogs())
 	assert.Equal(t, len(want), sink.LogRecordCount())
 	sink.Reset()
-	assert.Equal(t, 0, len(sink.AllLogs()))
+	assert.Empty(t, sink.AllLogs())
 	assert.Equal(t, 0, sink.LogRecordCount())
 }
 
@@ -72,5 +72,5 @@ func TestProfilesSink(t *testing.T) {
 	}
 	assert.Equal(t, want, sink.AllProfiles())
 	sink.Reset()
-	assert.Equal(t, 0, len(sink.AllProfiles()))
+	assert.Empty(t, sink.AllProfiles())
 }