adding comments

Signed-off-by: Andreas Gkizas <[email protected]>

Author: gizas

receiver/otlpreceiver/internal/errors/errors.go

@@ -53,6 +53,12 @@ func GetStatusFromError(err error) error {
 		// For client disconnection errors, we want to ensure they are marked as retryable
 		// and provide a descriptive message
 		s = status.New(codes.Unavailable, GetClientDisconnectMessage(err))
+	} else if consumererror.IsPermanent(err) {
+		// For permanent errors, convert to InvalidArgument (equivalent to HTTP 400)
+		s = status.New(codes.InvalidArgument, err.Error())
+	} else {
+		// For non-permanent errors, convert to Unavailable (equivalent to HTTP 503)
+		s = status.New(codes.Unavailable, err.Error())
 	}
 	return s.Err()
 }

receiver/otlpreceiver/internal/trace/otlp.go

@@ -41,6 +41,12 @@ func (r *Receiver) Export(ctx context.Context, req ptraceotlp.ExportRequest) (pt
 	err := r.nextConsumer.ConsumeTraces(ctx, td)
 	r.obsreport.EndTracesOp(ctx, dataFormatProtobuf, spanCount, err)
 
+	// Use appropriate status codes for permanent/non-permanent errors
+	// If we return the error straightaway, then the grpc implementation will set status code to Unknown
+	// Refer: https://github.com/grpc/grpc-go/blob/v1.59.0/server.go#L1345
+	// So, convert the error to appropriate grpc status and return the error
+	// NonPermanent errors will be converted to codes.Unavailable (equivalent to HTTP 503)
+	// Permanent errors will be converted to codes.InvalidArgument (equivalent to HTTP 400)
 	if err != nil {
 		return ptraceotlp.NewExportResponse(), errors.GetStatusFromError(err)
 	}