Skip to content

Commit 25ea91a

Browse files
committed
added tests to improve coverage
Signed-off-by: Andreas Gkizas <[email protected]>
1 parent f0297ff commit 25ea91a

File tree

4 files changed

+69
-0
lines changed

4 files changed

+69
-0
lines changed

exporter/exporterhelper/logs_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,20 @@ func TestLogsRequest(t *testing.T) {
5959
)
6060
}
6161

62+
func TestLogsEncoding_UnmarshalError(t *testing.T) {
63+
fgOrigReadState := queue.PersistRequestContextOnRead
64+
queue.PersistRequestContextOnRead = func() bool { return false }
65+
t.Cleanup(func() {
66+
queue.PersistRequestContextOnRead = fgOrigReadState
67+
})
68+
69+
enc := logsEncoding{}
70+
ctx, req, err := enc.Unmarshal([]byte("!invalid-proto"))
71+
assert.Error(t, err)
72+
assert.Nil(t, req)
73+
assert.NotNil(t, ctx)
74+
}
75+
6276
func TestLogs_InvalidName(t *testing.T) {
6377
le, err := NewLogs(context.Background(), exportertest.NewNopSettings(exportertest.NopType), nil, newPushLogsData(nil))
6478
require.Nil(t, le)

exporter/exporterhelper/metrics_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,20 @@ func TestMetricsRequest(t *testing.T) {
5959
)
6060
}
6161

62+
func TestMetricsEncoding_UnmarshalError(t *testing.T) {
63+
fgOrigReadState := queue.PersistRequestContextOnRead
64+
queue.PersistRequestContextOnRead = func() bool { return false }
65+
t.Cleanup(func() {
66+
queue.PersistRequestContextOnRead = fgOrigReadState
67+
})
68+
69+
enc := metricsEncoding{}
70+
ctx, req, err := enc.Unmarshal([]byte("!invalid-proto"))
71+
assert.Error(t, err)
72+
assert.Nil(t, req)
73+
assert.NotNil(t, ctx)
74+
}
75+
6276
func TestMetrics_NilConfig(t *testing.T) {
6377
me, err := NewMetrics(context.Background(), exportertest.NewNopSettings(exportertest.NopType), nil, newPushMetricsData(nil))
6478
require.Nil(t, me)

exporter/exporterhelper/traces_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,20 @@ func TestTracesRequest(t *testing.T) {
5555
assert.Equal(t, newTracesRequest(ptrace.NewTraces()), mr.(RequestErrorHandler).OnError(traceErr))
5656
}
5757

58+
func TestTracesEncoding_UnmarshalError(t *testing.T) {
59+
fgOrigReadState := queue.PersistRequestContextOnRead
60+
queue.PersistRequestContextOnRead = func() bool { return false }
61+
t.Cleanup(func() {
62+
queue.PersistRequestContextOnRead = fgOrigReadState
63+
})
64+
65+
enc := tracesEncoding{}
66+
ctx, req, err := enc.Unmarshal([]byte("!invalid-proto"))
67+
assert.Error(t, err)
68+
assert.Nil(t, req)
69+
assert.NotNil(t, ctx)
70+
}
71+
5872
func TestTraces_InvalidName(t *testing.T) {
5973
te, err := NewTraces(context.Background(), exportertest.NewNopSettings(exportertest.NopType), nil, newTraceDataPusher(nil))
6074
require.Nil(t, te)

receiver/receiverhelper/obsreport_test.go

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,15 @@ func TestCheckReceiverTracesViews(t *testing.T) {
503503
Value: int64(0),
504504
},
505505
}, metricdatatest.IgnoreTimestamp(), metricdatatest.IgnoreExemplars())
506+
metadatatest.AssertEqualReceiverFailedSpans(t, tt,
507+
[]metricdata.DataPoint[int64]{
508+
{
509+
Attributes: attribute.NewSet(
510+
attribute.String(internal.ReceiverKey, receiverID.String()),
511+
attribute.String(internal.TransportKey, transport)),
512+
Value: int64(0),
513+
},
514+
}, metricdatatest.IgnoreTimestamp(), metricdatatest.IgnoreExemplars())
506515
}
507516

508517
func TestCheckReceiverMetricsViews(t *testing.T) {
@@ -537,6 +546,15 @@ func TestCheckReceiverMetricsViews(t *testing.T) {
537546
Value: int64(0),
538547
},
539548
}, metricdatatest.IgnoreTimestamp(), metricdatatest.IgnoreExemplars())
549+
metadatatest.AssertEqualReceiverFailedMetricPoints(t, tt,
550+
[]metricdata.DataPoint[int64]{
551+
{
552+
Attributes: attribute.NewSet(
553+
attribute.String(internal.ReceiverKey, receiverID.String()),
554+
attribute.String(internal.TransportKey, transport)),
555+
Value: int64(0),
556+
},
557+
}, metricdatatest.IgnoreTimestamp(), metricdatatest.IgnoreExemplars())
540558
}
541559

542560
func TestCheckReceiverLogsViews(t *testing.T) {
@@ -571,6 +589,15 @@ func TestCheckReceiverLogsViews(t *testing.T) {
571589
Value: int64(0),
572590
},
573591
}, metricdatatest.IgnoreTimestamp(), metricdatatest.IgnoreExemplars())
592+
metadatatest.AssertEqualReceiverFailedLogRecords(t, tt,
593+
[]metricdata.DataPoint[int64]{
594+
{
595+
Attributes: attribute.NewSet(
596+
attribute.String(internal.ReceiverKey, receiverID.String()),
597+
attribute.String(internal.TransportKey, transport)),
598+
Value: int64(0),
599+
},
600+
}, metricdatatest.IgnoreTimestamp(), metricdatatest.IgnoreExemplars())
574601
}
575602

576603
func testTelemetry(t *testing.T, testFunc func(t *testing.T, tt *componenttest.Telemetry)) {

0 commit comments

Comments
 (0)