fix(flagd): no retry for certain error codes, implement test steps #1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Kavindu-Dodan,
beeme1mr,
thisthat and
toddbaert
aepfli
reviewed
Nov 10, 2025
...lagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/config/ConfigSteps.java
Show resolved
Hide resolved
aepfli
reviewed
Nov 10, 2025
| .statusCode(200); | ||
| } | ||
|
|
||
| @Then("the client is in {} state") |
Member
There was a problem hiding this comment.
we should do the renaming of this step as described here open-feature/flagd-testbed#306 before merging
aepfli
reviewed
Nov 10, 2025
| case "CacheType": | ||
| return CacheType.valueOf(value.toUpperCase()).getValue(); | ||
| case "StringList": | ||
| return List.of(value); |
Member
There was a problem hiding this comment.
Not sure about the structure of the step, but i would assume, that there can be multiple values within the string, and that we maybe should split and trim it, before creating a list.
Member
Author
There was a problem hiding this comment.
Yes, i also think so, but I wasn't sure of what the separator to use here. Have we agreed on one?
aepfli
reviewed
Nov 10, 2025
| * Defaults to empty list | ||
| */ | ||
| @Builder.Default | ||
| private List<String> nonRetryableStatusCodes = new ArrayList<>(); |
Member
There was a problem hiding this comment.
As within the documentation the option has a dedicated name, we should keep to the specification, so this property has the same name in all the providers.
Signed-off-by: lea konvalinka <[email protected]>
leakonvalinka
force-pushed
the
fix/flagd-infinite-connection-retries
branch
from
6f89ff0 to
057751b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1234523
Notes
Follow-up Tasks
How to test