Skip to content

Conversation

@toddbaert
Copy link
Member

@toddbaert toddbaert commented Jul 31, 2023

Add replace directive for broken package.

https://go.buf.build/open-feature/flagd-connect/open-feature/flagd no longer resolves (this has been deprecated).

Unfortunately, for some reasons, this is still being added to some go.sum files. I have no idea why, I can't seem to force it to be updated. This adds a replace directive for this dep.

To fix this, we have to drop support for 1.16 and lower, it seems: #291 (comment)

Github did something really odd and stopped updating this PR even though I was pushing new commits. See here.

@toddbaert toddbaert requested a review from Kavindu-Dodan July 31, 2023 17:52
@toddbaert toddbaert requested a review from a team as a code owner July 31, 2023 17:52
@github-actions github-actions bot requested a review from rcrowe July 31, 2023 17:52
Comment on lines -1109 to -1110
go.buf.build/open-feature/flagd-connect/open-feature/flagd v1.1.3/go.mod h1:ZaEOUjTu/oxTFHuwNjF2788REepgWYPsU4Ty6lPIMzc=
go.buf.build/open-feature/flagd-connect/open-feature/flagd v1.1.4/go.mod h1:ZaEOUjTu/oxTFHuwNjF2788REepgWYPsU4Ty6lPIMzc=
Copy link
Member Author

@toddbaert toddbaert Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kavindu-Dodan this is the "bad" dep. Its seems to be coming in via the sdk, but I can't understand why (the SDK version seems new enough that it shouldn't need this).

@toddbaert
Copy link
Member Author

toddbaert commented Jul 31, 2023

@Kavindu-Dodan I figured it out. It seem the issue is related to the go 1.13 compatibility in the config-cat module. Moving this to 1.18, and doing go mod tidy -compat=1.18 fixes the issue.

cc @rcrowe are you OK to migrate this to 1.18? That's also the version required by the latest SDK.

@toddbaert toddbaert changed the title fix: replace old flagd dependency chore!: update minimum go version Jul 31, 2023
@toddbaert
Copy link
Member Author

cc @thomaspoignant very interesting stuff here - looks like this should resolve our CI issues.

@toddbaert toddbaert closed this Jul 31, 2023
@Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan I figured it out. It seem the issue is related to the go 1.13 compatibility in the config-cat module. Moving this to 1.18, and doing go mod tidy -compat=1.18 fixes the issue.

cc @rcrowe are you OK to migrate this to 1.18? That's also the version required by the latest SDK.

Another alternative is to release go-sdk version which removes the circular dependency at go-sdk [1] & update this

[1] - open-feature/go-sdk#205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants