Skip to content

Commit 5e21546

Browse files
authored
Cleanups (#570)
1 parent a459759 commit 5e21546

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+566
-533
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 0 additions & 24 deletions
This file was deleted.
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
name: Bug Report
2+
description: File a bug report
3+
body:
4+
- type: markdown
5+
attributes:
6+
value: |
7+
Thank you for taking the time to fill out this bug report!
8+
Before you get started, please ensure there's [no existing issue](https://github.com/open-cli-tools/concurrently/issues) with the same concern!
9+
- type: textarea
10+
attributes:
11+
label: Describe the Bug
12+
value: |
13+
<!--
14+
15+
Please provide the following information:
16+
17+
- Description: Clear and concise description of what the bug is
18+
- Expected Behavior: What you expected to happen
19+
- Environment: At least the OS, Node.js, and concurrently's versions
20+
- Reproduction: A way to reproduce the issue
21+
22+
Our time to work on this project is limited.
23+
With an accurate report you're helping us to understand and solve the request faster.
24+
Please understand that reports that do not meet the requirements may be closed without further notice.
25+
26+
Thank you!
27+
28+
-->
29+
validations:
30+
required: true
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
name: Feature Request
2+
description: Open a feature request
3+
body:
4+
- type: markdown
5+
attributes:
6+
value: |
7+
Thank you for taking the time to fill out this feature request!
8+
Before you get started, please ensure there's [no existing issue](https://github.com/open-cli-tools/concurrently/issues) with the same concern!
9+
- type: textarea
10+
attributes:
11+
label: Describe the Feature Request
12+
value: |
13+
<!--
14+
15+
Please provide the following information:
16+
17+
- Description: Clear and concise description of what you want
18+
- Use Case: Why is this needed and what is a use case for it
19+
20+
Our time to work on this project is limited.
21+
With an accurate report you're helping us to understand and solve the request faster.
22+
Please understand that reports that do not meet the requirements may be closed without further notice.
23+
24+
Thank you!
25+
26+
-->
27+
validations:
28+
required: true

.github/actions/setup/action.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@ runs:
1313
using: composite
1414
steps:
1515
- name: Install Node.js
16-
uses: actions/setup-node@v4
16+
uses: actions/setup-node@v5
1717
with:
1818
node-version-file: ${{ !inputs.node-version && '.node-version' || '' }}
1919
node-version: ${{ inputs.node-version }}
2020
registry-url: ${{ inputs.node-registry }}
21+
package-manager-cache: false
2122

2223
- name: Install pnpm
2324
uses: pnpm/action-setup@v4

.github/workflows/test.yml renamed to .github/workflows/ci.yml

Lines changed: 23 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,39 @@
1-
name: Test
1+
name: CI
22

33
on:
44
push:
55
branches:
66
- main
7-
paths-ignore:
8-
- '**.md'
9-
- '**.ya?ml'
10-
- '!pnpm-lock.yaml'
11-
- '!.github/workflows/test.yml'
127
pull_request:
138
branches:
149
- main
15-
paths-ignore:
16-
- '**.md'
17-
- '**.ya?ml'
18-
- '!pnpm-lock.yaml'
19-
- '!.github/workflows/test.yml'
2010

2111
concurrency:
2212
group: ${{ github.workflow }}-${{ github.ref }}
2313
cancel-in-progress: true
2414

2515
jobs:
16+
lint:
17+
name: Lint
18+
runs-on: ubuntu-latest
19+
steps:
20+
- name: Checkout repository
21+
uses: actions/checkout@v5
22+
23+
- name: Setup
24+
uses: ./.github/actions/setup
25+
26+
- name: Lint
27+
run: pnpm run lint
28+
29+
- name: Format
30+
run: pnpm run format
31+
32+
- name: Typecheck
33+
run: pnpm run typecheck
34+
2635
test:
27-
name: Node.js ${{ matrix.node }} on ${{ matrix.os.name }}
36+
name: Test (Node.js ${{ matrix.node }}, ${{ matrix.os.name }})
2837
runs-on: ${{ matrix.os.version }}
2938
strategy:
3039
fail-fast: false
@@ -49,11 +58,8 @@ jobs:
4958
with:
5059
node-version: ${{ matrix.node }}
5160

52-
- name: Install concurrently 🐶🥣
53-
run: pnpm add --global concurrently
54-
55-
- name: Build & Test
56-
run: concurrently --prefix none --group "pnpm:build" "pnpm:test --coverage" "pnpm:test:smoke"
61+
- name: Test
62+
run: pnpm exec vitest --coverage
5763

5864
- name: Submit coverage
5965
uses: coverallsapp/github-action@master

.github/workflows/lint-format.yml

Lines changed: 0 additions & 30 deletions
This file was deleted.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ Check out documentation and other usage examples in the [`docs` directory](./doc
104104
- `prefix`: the prefix type to use when logging processes output.
105105
Possible values: `index`, `pid`, `time`, `command`, `name`, `none`, or a template (eg `[{time} process: {pid}]`).
106106
Default: the name of the process, or its index if no name is set.
107-
- `prefixColors`: a list of colors or a string as supported by [chalk](https://www.npmjs.com/package/chalk) and additional style `auto` for an automatically picked color.
107+
- `prefixColors`: a list of colors or a string as supported by [Chalk](https://www.npmjs.com/package/chalk) and additional style `auto` for an automatically picked color.
108108
If concurrently would run more commands than there are colors, the last color is repeated, unless if the last color value is `auto` which means following colors are automatically picked to vary.
109109
Prefix colors specified per-command take precedence over this list.
110110
- `prefixLength`: how many characters to show when prefixing with `command`. Default: `10`
@@ -224,6 +224,6 @@ It contains the following properties:
224224
So _null_ means the process didn't terminate normally. This will make **concurrently**
225225
to return non-zero exit code too.
226226

227-
- Does this work with the npm-replacements [yarn](https://github.com/yarnpkg/yarn), [pnpm](https://pnpm.js.org/), or [Bun](https://bun.sh/)?
227+
- Does this work with the npm-replacements [yarn](https://yarnpkg.com/), [pnpm](https://pnpm.io/), or [Bun](https://bun.sh/)?
228228

229229
Yes! In all examples above, you may replace "`npm`" with "`yarn`", "`pnpm`", or "`bun`".

bin/fixtures/read-echo.js renamed to bin/__fixtures__/read-echo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable no-console */
1+
import process from 'node:process';
22

33
process.stdin.on('data', (chunk) => {
44
const line = chunk.toString().trim();

bin/fixtures/sleep.js renamed to bin/__fixtures__/sleep.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
* (Windows doesn't provide the 'sleep' command by default,
55
* see https://github.com/open-cli-tools/concurrently/issues/277)
66
*/
7+
import process from 'node:process';
78

8-
/* eslint-disable no-console */
9-
10-
const seconds = process.argv[2];
11-
if (!seconds || isNaN(seconds) || process.argv.length > 3) {
9+
const seconds = +process.argv[2];
10+
if (!seconds || Number.isNaN(seconds) || process.argv.length > 3) {
1211
// Mimic behavior from native 'sleep' command
1312
console.error('usage: sleep seconds');
1413
process.exit(1);
1514
}
15+
1616
await new Promise((resolve) => setTimeout(resolve, seconds * 1000));

0 commit comments

Comments
 (0)