add support for align none update #272

Author: olekukonko

renderer/markdown.go

@@ -140,10 +140,10 @@ func (m *Markdown) resolveAlignment(ctx tw.Formatting) tw.Alignment {
 
 	// build default alignment
 	for i := 0; i < total; i++ {
-		m.alignment = append(m.alignment, tw.AlignLeft)
+		m.alignment = append(m.alignment, tw.AlignNone) // Default to AlignNone
 	}
 
-	// add per colum alignment if it exits
+	// add per column alignment if it exists
 	for i := 0; i < total; i++ {
 		m.alignment[i] = ctx.Row.Current[i].Align
 	}
@@ -255,9 +255,10 @@ func (m *Markdown) formatSeparator(width int, align tw.Align) string {
 		sb.WriteRune(':')
 		sb.WriteString(strings.Repeat("-", targetWidth-2))
 		sb.WriteRune(':')
+	case tw.AlignNone:
+		sb.WriteString(strings.Repeat("-", targetWidth))
 	default:
-		sb.WriteRune(':')
-		sb.WriteString(strings.Repeat("-", targetWidth-1))
+		sb.WriteString(strings.Repeat("-", targetWidth)) // Fallback
 	}
 
 	result := sb.String()
@@ -321,7 +322,6 @@ func (m *Markdown) renderMarkdownLine(line []string, ctx tw.Formatting, isHeader
 
 		defaultPadding := tw.Padding{Left: tw.Space, Right: tw.Space}
 		if !ok {
-
 			cellCtx = tw.CellContext{
 				Data: tw.Empty, Align: align, Padding: defaultPadding,
 				Width: ctx.Row.Widths.Get(colIndex), Merge: tw.MergeState{},
@@ -339,18 +339,6 @@ func (m *Markdown) renderMarkdownLine(line []string, ctx tw.Formatting, isHeader
 
 		// Calculate width and span
 		span := 1
-
-		if align == tw.AlignNone || align == tw.Empty {
-			if ctx.Row.Position == tw.Header && !isHeaderSep {
-				align = tw.AlignCenter
-			} else if ctx.Row.Position == tw.Footer {
-				align = tw.AlignRight
-			} else {
-				align = tw.AlignLeft
-			}
-			m.logger.Debugf("renderMarkdownLine: Col %d using default align '%s'", colIndex, align)
-		}
-
 		visualWidth := 0
 		isHMergeStart := ok && cellCtx.Merge.Horizontal.Present && cellCtx.Merge.Horizontal.Start
 		if isHMergeStart {
@@ -383,10 +371,11 @@ func (m *Markdown) renderMarkdownLine(line []string, ctx tw.Formatting, isHeader
 			var formattedSegment string
 			if isHeaderSep {
 				// Use header's alignment from ctx.Row.Previous
-				headerAlign := tw.AlignCenter // Default for headers
+				headerAlign := align
 				if headerCellCtx, headerOK := ctx.Row.Previous[colIndex]; headerOK {
 					headerAlign = headerCellCtx.Align
-					if headerAlign == tw.AlignNone || headerAlign == tw.Empty {
+					// Preserve tw.AlignNone for separator
+					if headerAlign != tw.AlignNone && (headerAlign == tw.Empty || headerAlign == tw.Skip) {
 						headerAlign = tw.AlignCenter
 					}
 				}
@@ -403,6 +392,16 @@ func (m *Markdown) renderMarkdownLine(line []string, ctx tw.Formatting, isHeader
 						rowAlign = headerCellCtx.Align
 					}
 				}
+				if rowAlign == tw.AlignNone || rowAlign == tw.Empty {
+					if ctx.Row.Position == tw.Header {
+						rowAlign = tw.AlignCenter
+					} else if ctx.Row.Position == tw.Footer {
+						rowAlign = tw.AlignRight
+					} else {
+						rowAlign = tw.AlignLeft
+					}
+					m.logger.Debugf("renderMarkdownLine: Col %d using default align '%s'", colIndex, rowAlign)
+				}
 				formattedSegment = m.formatCell(content, visualWidth, rowAlign, cellCtx.Padding)
 			}
 			output.WriteString(formattedSegment)

tests/markdown_test.go

@@ -260,3 +260,29 @@ func TestMarkdownWithFooter(t *testing.T) {
 `
 	visualCheck(t, "MarkdownWithFooter", buf.String(), expected)
 }
+
+func TestMarkdownAlignmentNone(t *testing.T) {
+	t.Run("AlignNone", func(t *testing.T) {
+		var buf bytes.Buffer
+		table := tablewriter.NewTable(&buf, tablewriter.WithRenderer(renderer.NewMarkdown()))
+		table.Configure(func(cfg *tablewriter.Config) {
+			cfg.Header.Alignment.PerColumn = []tw.Align{tw.AlignNone}
+			cfg.Row.Alignment.PerColumn = []tw.Align{tw.AlignNone}
+			cfg.Debug = true
+		})
+		table.Header([]string{"Header"})
+		table.Append([]string{"Data"})
+		table.Render()
+
+		expected := `
+            | HEADER |
+            |--------|
+            | Data   |
+
+
+`
+		if !visualCheck(t, "AlignNone", buf.String(), expected) {
+			t.Fatal(table.Debug())
+		}
+	})
+}

tw/tw.go

@@ -15,6 +15,8 @@ const (
 	Skip    = ""
 	Space   = " "
 	NewLine = "\n"
+	Column  = ":"
+	Dash    = "-"
 )
 
 // Feature State Constants