minor cleanup and return WithSymbols

Author: olekukonko

deprecated.go

@@ -195,9 +195,16 @@ func (rf *RowFormattingBuilder) WithAlignment(align tw.Align) *RowFormattingBuil
 	return rf
 }
 
-// Deprecated:Use WithMaxWidth instead.
-// WithTableMax sets a global maximum table width for the table.
+// WithTableMax sets the maximum width of the entire table in characters.
 // Negative values are ignored, and the change is logged if debugging is enabled.
+// The width constrains the table's rendering, potentially causing text wrapping or truncation
+// based on the configuration's wrapping settings (e.g., tw.WrapTruncate).
+// If debug logging is enabled via WithDebug(true), the applied width is logged.
+//
+// Deprecated: Use WithMaxWidth instead, which provides the same functionality with a clearer name
+// and consistent naming across the package. For example:
+//
+//	tablewriter.NewTable(os.Stdout, tablewriter.WithMaxWidth(80))
 func WithTableMax(width int) Option {
 	return func(target *Table) {
 		if width < 0 {
@@ -209,19 +216,3 @@ func WithTableMax(width int) Option {
 		}
 	}
 }
-
-// Deprecated:Use Rederer setting directly
-// not al lrenderes have symboms or support Renditions
-// WithSymbols sets the symbols used for table drawing and updates the renderer's configuration.
-// Logs the change if debugging is enabled.
-func WithSymbols(symbols tw.Symbols) Option {
-	return func(target *Table) {
-		if target.renderer != nil {
-			cfg := target.renderer.Config()
-			cfg.Symbols = symbols
-			if target.logger != nil {
-				target.logger.Debug("Option: WithSymbols applied to Table.")
-			}
-		}
-	}
-}

option.go

@@ -3,20 +3,9 @@ package tablewriter
 import (
 	"github.com/olekukonko/ll"
 	"github.com/olekukonko/tablewriter/tw"
-	"io"
 	"reflect"
 )
 
-// NewWriter creates a new table with default settings for backward compatibility.
-// It logs the creation if debugging is enabled.
-func NewWriter(w io.Writer) *Table {
-	t := NewTable(w)
-	if t.logger != nil {
-		t.logger.Debug("NewWriter created buffered Table")
-	}
-	return t
-}
-
 // Option defines a function type for configuring a Table instance.
 type Option func(target *Table)
 
@@ -624,6 +613,29 @@ func WithRendition(rendition tw.Rendition) Option {
 	}
 }
 
+// WithSymbols sets the symbols used for drawing table borders and separators.
+// The symbols are applied to the table's renderer configuration, if a renderer is set.
+// If no renderer is set (target.renderer is nil), this option has no effect. .
+func WithSymbols(symbols tw.Symbols) Option {
+	return func(target *Table) {
+		if target.renderer != nil {
+			cfg := target.renderer.Config()
+			cfg.Symbols = symbols
+
+			if ru, ok := target.renderer.(tw.Renditioning); ok {
+				ru.Rendition(cfg)
+				if target.logger != nil {
+					target.logger.Debugf("Option: WithRendition: Applied to renderer via Renditioning.SetRendition(): %+v", cfg)
+				}
+			} else {
+				if target.logger != nil {
+					target.logger.Warnf("Option: WithRendition: Current renderer type %T does not implement tw.Renditioning. Rendition may not be applied as expected.", target.renderer)
+				}
+			}
+		}
+	}
+}
+
 // defaultConfig returns a default Config with sensible settings for headers, rows, footers, and behavior.
 func defaultConfig() Config {
 	return Config{

tablewriter.go

@@ -133,6 +133,16 @@ func NewTable(w io.Writer, opts ...Option) *Table {
 	return t
 }
 
+// NewWriter creates a new table with default settings for backward compatibility.
+// It logs the creation if debugging is enabled.
+func NewWriter(w io.Writer) *Table {
+	t := NewTable(w)
+	if t.logger != nil {
+		t.logger.Debug("NewWriter created buffered Table")
+	}
+	return t
+}
+
 // Caption sets the table caption (legacy method).
 // Defaults to BottomCenter alignment, wrapping to table width.
 // Use SetCaptionOptions for more control.