Skip to content

Commit e0cc3ad

Browse files
teleskop150750productdevbook
authored andcommitted
fix: useDismissableLayer attrs
1 parent 6de292e commit e0cc3ad

File tree

2 files changed

+6
-41
lines changed

2 files changed

+6
-41
lines changed

packages/vue-primitives/src/dialog/DialogContentImpl.ts

Lines changed: 3 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -30,26 +30,14 @@ export function useDialogContentImpl(props: UseDialogContentImplProps): RadixPri
3030

3131
const useDialogContentImpl = context.modal ? useDialogContentModal : useDialogContentNonModal
3232

33-
const dialogContentImpl = useDialogContentImpl({
33+
return useDialogContentImpl({
3434
onOpenAutoFocus: props.onOpenAutoFocus,
3535
onCloseAutoFocus: props.onCloseAutoFocus,
3636
onEscapeKeydown: props.onEscapeKeydown,
3737
onPointerdownOutside: props.onPointerdownOutside,
3838
onFocusOutside: props.onFocusOutside,
3939
onInteractOutside: props.onInteractOutside,
4040
})
41-
42-
return {
43-
attrs(extraAttrs = []) {
44-
const attrs = dialogContentImpl.attrs()
45-
46-
if (extraAttrs && extraAttrs.length > 0) {
47-
mergePrimitiveAttrs(attrs, extraAttrs)
48-
}
49-
50-
return attrs
51-
},
52-
}
5341
}
5442

5543
export function useDialogContentModal(props: UseDialogContentImplProps): RadixPrimitiveReturns {
@@ -61,7 +49,7 @@ export function useDialogContentModal(props: UseDialogContentImplProps): RadixPr
6149
hideOthers(context.content.value)
6250
})
6351

64-
const dialogContentImpl = useDialogContentImplShared({
52+
return useDialogContentImplShared({
6553
trapFocus() {
6654
return context.open.value
6755
},
@@ -98,18 +86,6 @@ export function useDialogContentModal(props: UseDialogContentImplProps): RadixPr
9886
},
9987
onEscapeKeydown: props.onEscapeKeydown,
10088
})
101-
102-
return {
103-
attrs(extraAttrs) {
104-
const attrs = dialogContentImpl.attrs()
105-
106-
if (extraAttrs && extraAttrs.length > 0) {
107-
mergePrimitiveAttrs(attrs, extraAttrs)
108-
}
109-
110-
return attrs
111-
},
112-
}
11389
}
11490

11591
export function useDialogContentNonModal(props: UseDialogContentImplProps): RadixPrimitiveReturns {
@@ -118,7 +94,7 @@ export function useDialogContentNonModal(props: UseDialogContentImplProps): Radi
11894
let hasInteractedOutsideRef = false
11995
let hasPointerDownOutsideRef = false
12096

121-
const dialogContentImpl = useDialogContentImplShared({
97+
return useDialogContentImplShared({
12298
trapFocus() {
12399
return false
124100
},
@@ -168,18 +144,6 @@ export function useDialogContentNonModal(props: UseDialogContentImplProps): Radi
168144
onFocusOutside: props.onFocusOutside,
169145
onEscapeKeydown: props.onEscapeKeydown,
170146
})
171-
172-
return {
173-
attrs(extraAttrs = []) {
174-
const attrs = dialogContentImpl.attrs()
175-
176-
if (extraAttrs && extraAttrs.length > 0) {
177-
mergePrimitiveAttrs(attrs, extraAttrs)
178-
}
179-
180-
return attrs
181-
},
182-
}
183147
}
184148

185149
export interface UseDialogContentImplSharedProps extends EmitsToHookProps<DialogContentImplPublicEmits>, Omit<UseDismissableLayerProps, 'onDismiss'> {

packages/vue-primitives/src/dismissable-layer/DismissableLayer.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,8 @@ export function useDismissableLayer(props: UseDismissableLayerProps = {}): Radix
178178

179179
return {
180180
attrs(extraAttrs = []) {
181-
const attrs: PrimitiveElAttrs = {
181+
const attrs = {}
182+
const overideAttrs: PrimitiveElAttrs = {
182183
'elRef': setTemplateEl,
183184
'data-dismissable-layer': true,
184185
'style': {
@@ -190,7 +191,7 @@ export function useDismissableLayer(props: UseDismissableLayerProps = {}): Radix
190191
},
191192
}
192193

193-
mergePrimitiveAttrs({}, [...extraAttrs, attrs])
194+
mergePrimitiveAttrs(attrs, [...extraAttrs, overideAttrs])
194195

195196
return attrs
196197
},

0 commit comments

Comments
 (0)