Skip to content

Commit ff18f61

Browse files
cecigarciaokonet
authored andcommitted
fix: Prevent component from being updated after it gets unmounted (#49)
Prevents container dimensions from being updated after it gets unmounted Fixes #48
1 parent 649ca20 commit ff18f61

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/index.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,23 @@ export default class ContainerDimensions extends Component {
3030
callOnAdd: false
3131
})
3232
this.elementResizeDetector.listenTo(this.parentNode, this.onResize)
33+
this.componentIsMounted = true
3334
this.onResize()
3435
}
3536

3637
componentWillUnmount() {
38+
this.componentIsMounted = false
3739
this.elementResizeDetector.uninstall(this.parentNode)
3840
}
3941

4042
onResize() {
4143
const clientRect = ContainerDimensions.getDomNodeDimensions(this.parentNode)
42-
this.setState({
43-
initiated: true,
44-
...clientRect
45-
})
44+
if (this.componentIsMounted) {
45+
this.setState({
46+
initiated: true,
47+
...clientRect
48+
})
49+
}
4650
}
4751

4852
render() {

0 commit comments

Comments
 (0)