Resolve issues discovered by copilot.

Author: vdbergh

server/fishtest/static/js/application.js

@@ -654,6 +654,12 @@ function remainingApiCalls(response) {
 // URL.parse is too recent to use
 
 function parseRepo(url) {
+  // First check that this is a github repo
+  const re =
+    /^https:\/\/(www\.)?github\.com\/[A-Za-z0-9_.-]+\/[A-Za-z0-9_.-]+\/?$/;
+  if (!url.match(re)) {
+    throw new Error(`The url ${url} is not a GitHub repo`);
+  }
   const chunks = url.split("/");
   const user = chunks[3];
   const repo = chunks[4];

server/fishtest/static/js/pull_request.js

@@ -259,7 +259,7 @@ class PullRequest {
       if (!run.args.sprt.state) {
         throw new Error("Pull requests can only contain finished tests");
       }
-      if (run.args.new_tc && !run.args.tc != !run.args.new_tc) {
+      if (run.args.new_tc && run.args.tc != run.args.new_tc) {
         throw new Error("Pull requests cannot contain time odds tests");
       }
       this.runIdCache[runId] = run;
@@ -299,7 +299,7 @@ class PullRequest {
         }
         branch = run.args.new_tag;
         tests_repo = run.args.tests_repo;
-        latest = runs.start_time;
+        latest = run.start_time;
       }
     }
     let user, repo;
@@ -410,11 +410,7 @@ class PullRequest {
     };
     let body = await this.renderBody(token);
     body = body.replaceAll("<br>", "\n");
-    if (this.title) {
-      options.title = escapeHtml(this.title);
-    } else {
-      options.title = await this.renderTitle(token);
-    }
+    options.title = await this.renderTitle(token);
     options.body = body;
     // TODO Incorporate user
     if (this.numberCache[userData.branch]) {

server/fishtest/templates/pull_request.mak

@@ -68,7 +68,9 @@
             submitBtn.textContent="Submit";
           }
       } catch(e) {
-        console.log(e);
+        const text = await processError(e);
+	alertError(text);
+	console.error(text);
       }
       previewTab.addEventListener("click", async () => {
 	  PR.title = titleElt.value;