update github actions

Author: jbleyel

.github/workflows/auto-tag.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Git
         run: |

.github/workflows/build.yml

@@ -37,7 +37,7 @@ jobs:
           cheetah compile -R plugin
           python testsuite/evil_eval.py
 
-      - uses: actions/setup-python@v4
+      - uses: actions/setup-python@v5
         with:
           python-version: '3.11'
 
@@ -48,7 +48,7 @@ jobs:
           cheetah compile -R plugin
           python testsuite/evil_eval.py
 
-      - uses: actions/setup-python@v4
+      - uses: actions/setup-python@v5
         with:
           python-version: '3.10'
 

.github/workflows/ruff.yml

@@ -0,0 +1,29 @@
+name: Ruff Linter
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.12'
+
+      - name: Install Ruff
+        run: |
+          python -m pip install --upgrade pip
+          pip install ruff
+
+      - name: Run Ruff
+        run: |
+          ruff check .

plugin/controllers/defaults.py

@@ -233,7 +233,7 @@ def getATSearchtypes():
 
 def getTextInputSupport():
 	try:
-		from enigma import setPrevAsciiCode
+		from enigma import setPrevAsciiCode  # noqa: F401
 		return True
 	except ImportError:
 		return False

plugin/controllers/models/info.py

@@ -783,7 +783,7 @@ def getStatusInfo(self):
 	# Get recording state
 	try:
 		recs = NavigationInstance.instance.getAnyRecordingsCount()
-	except:
+	except:  # nosec # noqa: E722
 		recs = NavigationInstance.instance.getRecordings()
 	if recs:
 		statusinfo["isRecording"] = "true"

plugin/controllers/models/movies.py

@@ -693,7 +693,7 @@ def setMovieResumePoint(sref, resumepoint):
 			try:
 				from Screens.InfoBarGenerics import resumePointCache
 				resumePointCache[service.ref.toString()] = (int(time()), resumepoint, length * 90000)
-			except:
+			except:  # nosec # noqa: E722
 				pass
 
 		fullpath = service.ref.getPath()

plugin/controllers/views/responsive/ajax/renderevtblock.py

@@ -2,7 +2,7 @@
 
 from time import localtime, strftime
 from urllib.parse import quote
-from Plugins.Extensions.OpenWebif.controllers.i18n import tstrings
+# from Plugins.Extensions.OpenWebif.controllers.i18n import tstrings
 
 
 class renderEvtBlock:

plugin/httpserver.py

@@ -336,7 +336,7 @@ def noShell(self, user):
 		return False
 
 	def render(self, request):
-		host = request.getHost().host
+		# host = request.getHost().host
 		peer = request.getClientAddress().host
 		if peer is None:
 			peer = request.transport.socket.getpeername()[0]
@@ -348,7 +348,7 @@ def render(self, request):
 			peer = peer.split("%")[0]
 
 		if self.login(request.getUser(), request.getPassword(), peer) is False:
-			request.setHeader('WWW-authenticate', f'Basic realm="OpenWebif"')
+			request.setHeader('WWW-authenticate', 'Basic realm="OpenWebif"')
 			errpage = resource.ErrorPage(http.UNAUTHORIZED, "Unauthorized", "401 Authentication required")
 			return errpage.render(request)
 		else:
@@ -425,7 +425,7 @@ def getChildWithDefault(self, path, request):
 			return self.resource.getChildWithDefault(path, request)
 
 		if self.login(ruser, rpw, peer) is False:
-			request.setHeader('WWW-authenticate', f'Basic realm="OpenWebif"')
+			request.setHeader('WWW-authenticate', 'Basic realm="OpenWebif"')
 			return resource.ErrorPage(http.UNAUTHORIZED, "Unauthorized", "401 Authentication required")
 		else:
 			session["logged"] = True
@@ -493,7 +493,7 @@ def installCertificates(session):
 	certgenerator = SSLCertificateGenerator()
 	try:
 		certgenerator.installCertificates()
-	except OSError as e:
+	except OSError:
 		# Disable https
 		config.OpenWebif.https_enabled.value = False
 		config.OpenWebif.https_enabled.save()

pyproject.toml

@@ -0,0 +1,23 @@
+[tool.ruff]
+builtins = ["_"]
+line-length = 400
+select = ["E","F","W"]
+ignore = [
+	"W191"   # Indentation contains tabs
+]
+
+[tool.isort]
+profile = "black"
+line_length = 1000
+force_sort_within_sections = true
+combine_as_imports = true
+lines_between_types = 1
+include_trailing_comma = true
+multi_line_output = 3
+force_single_line = false
+default_section = "THIRDPARTY"
+sections = ["STDLIB", "THIRDPARTY", "FIRSTPARTY", "LOCALFOLDER"]
+known_third_party = ["Components", "Screens", "Tools"]
+known_first_party = ["Plugins"]
+no_lines_before = ["STDLIB"]
+order_by_type = false