Skip to content

Commit f543c6a

Browse files
committed
refactor: review code
1 parent e95ac2f commit f543c6a

File tree

9 files changed

+259
-38
lines changed

9 files changed

+259
-38
lines changed

.dockerignore

Lines changed: 0 additions & 12 deletions
This file was deleted.

Dockerfile

Lines changed: 0 additions & 8 deletions
This file was deleted.

app.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ default_events:
3535
# - project_card
3636
# - project_column
3737
# - public
38-
# - pull_request
38+
- pull_request
3939
- pull_request_review
4040
- pull_request_review_comment
4141
# - push

example/case.js

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// callback hell example
2+
app.get("/details", function (req, res) {
3+
var name = req.query.name;
4+
console.log(name);
5+
6+
Scopus.find({ name: name },
7+
{ '_id': 0, 'authorId': 1 },
8+
function (err, result) {
9+
if (err) { }
10+
else {
11+
var searchResult = result[0]["authorId"];
12+
console.log(searchResult);
13+
var options = {
14+
url: "https://api.elsevier.com/content/author/author_id/"
15+
+ searchResult + "?apiKey",
16+
headers: { 'Accept': 'application/json' }
17+
};
18+
request(options, function (error, response, body) {
19+
if (error) {
20+
21+
// Print the error if one occurred
22+
console.error('error in Authors :', error);
23+
24+
// Print the response status code if a response was received
25+
console.log('statusCode:', response && response.statusCode);
26+
res.send("error")
27+
}
28+
else if (!error) {
29+
var jsonObj = JSON.parse(body);
30+
if (jsonObj['author-retrieval-response'] == undefined) {
31+
res.send("No details");
32+
}
33+
else {
34+
var reqData = jsonObj['author-retrieval-response'][0];
35+
var authprofile = reqData["author-profile"]
36+
var names = authprofile["preferred-name"]["indexed-name"]
37+
console.log(names);
38+
var citation = reqData["coredata"]["citation-count"];
39+
var query = { authorId: searchResult };
40+
41+
Scopus.findOneAndUpdate(query, {
42+
name: names,
43+
citationCount: citation
44+
}, function (err, doc, res) {
45+
if (err) {
46+
console.log("error");
47+
}
48+
else {
49+
console.log("success");
50+
}
51+
})
52+
res.render("details", { data: reqData });
53+
}
54+
}
55+
});
56+
}
57+
})
58+
});

index.js

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const search = require('./src/client.js')
1+
const { search, review, refactor } = require('./src/client.js')
22
const commands = require('probot-commands-pro')
33

44
module.exports = (app) => {
@@ -8,6 +8,33 @@ module.exports = (app) => {
88
})
99
return await context.octokit.issues.createComment(issueComment)
1010
})
11+
// wip: review code from code & add test
12+
// https://docs.github.com/en/issues/tracking-your-work-with-issues/creating-an-issue
13+
app.on('issues.opened', async (context) => {
14+
if (context.isBot)
15+
return
16+
const { issue } = context.payload
17+
// if the robot is mentioned in the issue body, reponse with a greeting
18+
19+
})
20+
// configure something
21+
app.on(['installation'], async (context) => {
22+
23+
})
24+
25+
26+
app.on(['pull_request_review_comment'], async (context) => {
27+
if (context.isBot)
28+
return
29+
const { comment, pull_request, pull_request_review_id } = context.payload
30+
31+
})
32+
33+
app.on(['pull_request_review_comment'], async (context) => {
34+
if (context.isBot)
35+
return
36+
37+
})
1138

1239
app.on(['issues.opened', 'issues.edited'], async (context) => {
1340
if (context.isBot)

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"@antfu/eslint-config": "^0.33.1",
2929
"@rollup/plugin-commonjs": "^23.0.3",
3030
"@rollup/plugin-node-resolve": "^15.0.1",
31+
"@rollup/plugin-terser": "^0.2.0",
3132
"eslint": "^8.29.0",
3233
"jest": "^29.0.0",
3334
"nock": "^13.0.5",

0 commit comments

Comments
 (0)