Skip to content

Commit d4a8972

Browse files
Takuto IkutaCommit Bot
authored andcommitted
[build] specify lower symbol level for x86/x64 simple chrome
This is to improve link time for x86/x64 board that was not done in https://chromium-review.googlesource.com/c/1360194 With this CL, link time of chrome for coral reduced from 14.4s to 4.9s From collected build log, I see 442 chrome builds for x64 targets in recent 2 days with 13.99s average link time. Can I improve productivity of those developers by this CL? Change-Id: I79f4ead0fa955524cfd849d40e7cb0ff4d1aa99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506925 Commit-Queue: Takuto Ikuta <[email protected]> Reviewed-by: James Cook <[email protected]> Reviewed-by: Dan Erat <[email protected]> Reviewed-by: Steven Bennetts <[email protected]> Cr-Commit-Position: refs/heads/master@{#638880}
1 parent b46cb22 commit d4a8972

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

build/config/compiler/compiler.gni

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,14 @@ if (symbol_level == -1) {
211211
# Use lower symbol level in Simple Chrome build for faster link time.
212212
# For Simple Chrome, this should take precedence over is_official_build,
213213
# turned on by --internal.
214-
symbol_level = 1
214+
if ((target_cpu == "x64" || target_cpu == "x86") && !is_debug) {
215+
# For release x86/x64 build, specify symbol_level=0 for faster link time.
216+
# x86/x64 shows backtraces with symbol_level=0 (arm requires
217+
# symbol_level=1).
218+
symbol_level = 0
219+
} else {
220+
symbol_level = 1
221+
}
215222
} else if ((!is_nacl && !is_linux && !is_fuchsia) || is_debug ||
216223
is_official_build || is_chromecast) {
217224
# Linux builds slower by having symbols as part of the target binary,

0 commit comments

Comments
 (0)