Skip to content

Commit 713085d

Browse files
MaajidCommit Bot
Maajid
authored and
Commit Bot
committed
Add metric for ARC Total engagement time, which is the sum of foreground and background.
Bug: 936355 Change-Id: I5d9e685ca063be7af28cf999adf249766209f911 Reviewed-on: https://chromium-review.googlesource.com/c/1491232 Commit-Queue: Maajid <[email protected]> Reviewed-by: Shao-Chuan Lee <[email protected]> Reviewed-by: Christopher Thompson <[email protected]> Cr-Commit-Position: refs/heads/master@{#636710}
1 parent 4a19282 commit 713085d

File tree

3 files changed

+37
-4
lines changed

3 files changed

+37
-4
lines changed

‎components/arc/metrics/arc_metrics_service.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,11 @@ void ArcMetricsService::RecordEngagementTimeToUmaIfNeeded() {
435435
"Arc.EngagementTime.Total", engagement_time_total_,
436436
base::TimeDelta::FromSeconds(1),
437437
base::TimeDelta::FromDays(1) + kUpdateEngagementTimePeriod, 50);
438+
UMA_HISTOGRAM_CUSTOM_TIMES(
439+
"Arc.EngagementTime.ArcTotal",
440+
engagement_time_foreground_ + engagement_time_background_,
441+
base::TimeDelta::FromSeconds(1),
442+
base::TimeDelta::FromDays(1) + kUpdateEngagementTimePeriod, 50);
438443
UMA_HISTOGRAM_CUSTOM_TIMES(
439444
"Arc.EngagementTime.Foreground", engagement_time_foreground_,
440445
base::TimeDelta::FromSeconds(1),

‎components/arc/metrics/arc_metrics_service_unittest.cc

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,8 @@ TEST_F(ArcMetricsServiceTest, RecordEngagementTimeSessionLocked) {
464464
TriggerRecordEngagementTimeToUma();
465465
tester.ExpectTimeBucketCount("Arc.EngagementTime.Total",
466466
base::TimeDelta::FromSeconds(0), 1);
467+
tester.ExpectTimeBucketCount("Arc.EngagementTime.ArcTotal",
468+
base::TimeDelta::FromSeconds(0), 1);
467469
tester.ExpectTimeBucketCount("Arc.EngagementTime.Foreground",
468470
base::TimeDelta::FromSeconds(0), 1);
469471
tester.ExpectTimeBucketCount("Arc.EngagementTime.Background",
@@ -480,6 +482,8 @@ TEST_F(ArcMetricsServiceTest, RecordEngagementTimeSessionActive) {
480482
TriggerRecordEngagementTimeToUma();
481483
tester.ExpectTimeBucketCount("Arc.EngagementTime.Total",
482484
base::TimeDelta::FromSeconds(1), 1);
485+
tester.ExpectTimeBucketCount("Arc.EngagementTime.ArcTotal",
486+
base::TimeDelta::FromSeconds(0), 1);
483487
tester.ExpectTimeBucketCount("Arc.EngagementTime.Foreground",
484488
base::TimeDelta::FromSeconds(0), 1);
485489
tester.ExpectTimeBucketCount("Arc.EngagementTime.Background",
@@ -497,6 +501,8 @@ TEST_F(ArcMetricsServiceTest, RecordEngagementTimeScreenDimmed) {
497501
TriggerRecordEngagementTimeToUma();
498502
tester.ExpectTimeBucketCount("Arc.EngagementTime.Total",
499503
base::TimeDelta::FromSeconds(0), 1);
504+
tester.ExpectTimeBucketCount("Arc.EngagementTime.ArcTotal",
505+
base::TimeDelta::FromSeconds(0), 1);
500506
tester.ExpectTimeBucketCount("Arc.EngagementTime.Foreground",
501507
base::TimeDelta::FromSeconds(0), 1);
502508
tester.ExpectTimeBucketCount("Arc.EngagementTime.Background",
@@ -518,6 +524,8 @@ TEST_F(ArcMetricsServiceTest, RecordEngagementTimeArcWindowFocused) {
518524
TriggerRecordEngagementTimeToUma();
519525
tester.ExpectTimeBucketCount("Arc.EngagementTime.Total",
520526
base::TimeDelta::FromSeconds(1), 1);
527+
tester.ExpectTimeBucketCount("Arc.EngagementTime.ArcTotal",
528+
base::TimeDelta::FromSeconds(1), 1);
521529
tester.ExpectTimeBucketCount("Arc.EngagementTime.Foreground",
522530
base::TimeDelta::FromSeconds(1), 1);
523531
tester.ExpectTimeBucketCount("Arc.EngagementTime.Background",
@@ -538,6 +546,8 @@ TEST_F(ArcMetricsServiceTest, RecordEngagementTimeNonArcWindowFocused) {
538546
TriggerRecordEngagementTimeToUma();
539547
tester.ExpectTimeBucketCount("Arc.EngagementTime.Total",
540548
base::TimeDelta::FromSeconds(1), 1);
549+
tester.ExpectTimeBucketCount("Arc.EngagementTime.ArcTotal",
550+
base::TimeDelta::FromSeconds(0), 1);
541551
tester.ExpectTimeBucketCount("Arc.EngagementTime.Foreground",
542552
base::TimeDelta::FromSeconds(0), 1);
543553
tester.ExpectTimeBucketCount("Arc.EngagementTime.Background",
@@ -556,6 +566,8 @@ TEST_F(ArcMetricsServiceTest, RecordEngagementTimeAppInBackground) {
556566
TriggerRecordEngagementTimeToUma();
557567
tester.ExpectTimeBucketCount("Arc.EngagementTime.Total",
558568
base::TimeDelta::FromSeconds(1), 1);
569+
tester.ExpectTimeBucketCount("Arc.EngagementTime.ArcTotal",
570+
base::TimeDelta::FromSeconds(1), 1);
559571
tester.ExpectTimeBucketCount("Arc.EngagementTime.Foreground",
560572
base::TimeDelta::FromSeconds(0), 1);
561573
tester.ExpectTimeBucketCount("Arc.EngagementTime.Background",
@@ -579,6 +591,8 @@ TEST_F(ArcMetricsServiceTest,
579591
TriggerRecordEngagementTimeToUma();
580592
tester.ExpectTimeBucketCount("Arc.EngagementTime.Total",
581593
base::TimeDelta::FromSeconds(1), 1);
594+
tester.ExpectTimeBucketCount("Arc.EngagementTime.ArcTotal",
595+
base::TimeDelta::FromSeconds(1), 1);
582596
tester.ExpectTimeBucketCount("Arc.EngagementTime.Foreground",
583597
base::TimeDelta::FromSeconds(1), 1);
584598
tester.ExpectTimeBucketCount("Arc.EngagementTime.Background",

‎tools/metrics/histograms/histograms.xml

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4475,6 +4475,19 @@ uploading your change for review.
44754475
</summary>
44764476
</histogram>
44774477

4478+
<histogram name="Arc.EngagementTime.ArcTotal" units="ms">
4479+
<owner>[email protected]</owner>
4480+
<owner>[email protected]</owner>
4481+
<owner>[email protected]</owner>
4482+
<summary>
4483+
Total of Arc.EngagementTime.Background and Arc.EngagementTime.Foreground.
4484+
Note that this differs from Arc.EngagementTime.Total in that this is the
4485+
ARC++ engagement time, while Arc.EngagementTime.Total is the CrOS total
4486+
engagement time on devices with ARC++ enabled. See Arc.EngagementTime.Total
4487+
for definition of engagement and further details.
4488+
</summary>
4489+
</histogram>
4490+
44784491
<histogram name="Arc.EngagementTime.Background" units="ms">
44794492
<owner>[email protected]</owner>
44804493
<owner>[email protected]</owner>
@@ -4501,11 +4514,12 @@ uploading your change for review.
45014514
<owner>[email protected]</owner>
45024515
<owner>[email protected]</owner>
45034516
<summary>
4504-
Total user session time (from login to logout) excluding times when user
4505-
&quot;disengages&quot;: screen is locked or dims down due to user idle.
4517+
Total CrOS user session time (from login to logout) excluding times when
4518+
user &quot;disengages&quot;: screen is locked or dims down due to user idle.
45064519
Engagement time metrics, along with foreground and background time, are only
4507-
collected on users with ARC++ enabled. All three metrics are accumulated and
4508-
recorded to UMA once a day.
4520+
collected on users with ARC++ enabled. All four metrics are accumulated and
4521+
recorded to UMA once a day. For Total ARC++ engagement time, please see
4522+
Arc.EngagementTime.ArcTotal.
45094523
</summary>
45104524
</histogram>
45114525

0 commit comments

Comments
 (0)