Unbind application volume adjustment gestures (#17634)

Closes #17272

Summary of the issue:
The application volume adjuster feature introduced in #16591 includes default keyboard gestures that:

1. Conflict with the default gestures used by NVDA Remote; and
2. Don't do anything by default, as the feature is disabled.

Description of user facing changes
These gestures are unbound by default. Users can still bind gestures to these commands from the input gestures dialog.

Description of development approach
Removed the `gesture` argument to the `script` decorator on `GlobalCommands.script_increaseApplicationsVolume`, `GlobalCommands.script_decreaseApplicationsVolume`, and `GlobalCommands.script_toggleApplicationsMute`.

Testing strategy:
Ran NVDA from source. Ensured that the commands were unbound by executing the previous keyboard gestures.
Re-bound the gestures in the input gestures dialog, and ensured they worked as expected.

Known issues with pull request:
None.

Author: SaschaCowley

source/globalCommands.py

@@ -4832,7 +4832,6 @@ def script_cycleSoundSplit(self, gesture: "inputCore.InputGesture") -> None:
 			"Increases the volume of other applications",
 		),
 		category=SCRCAT_AUDIO,
-		gesture="kb:NVDA+alt+pageUp",
 	)
 	def script_increaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -> None:
 		appsVolume._adjustAppsVolume(5)
@@ -4843,7 +4842,6 @@ def script_increaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -
 			"Decreases the volume of other applications",
 		),
 		category=SCRCAT_AUDIO,
-		gesture="kb:NVDA+alt+pageDown",
 	)
 	def script_decreaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -> None:
 		appsVolume._adjustAppsVolume(-5)
@@ -4864,7 +4862,6 @@ def script_toggleApplicationsVolumeAdjuster(self, gesture: "inputCore.InputGestu
 			"Mutes or unmutes other applications",
 		),
 		category=SCRCAT_AUDIO,
-		gesture="kb:NVDA+alt+delete",
 	)
 	def script_toggleApplicationsMute(self, gesture: "inputCore.InputGesture") -> None:
 		appsVolume._toggleAppsVolumeMute()

user_docs/en/changes.md

@@ -9,11 +9,9 @@
 * Support for math in PDFs has been added.
 This works for formulas with associated MathML, such as some files generated by newer versions of TeX/LaTeX.
 Currently this is only supported in Foxit Reader & Foxit Editor. (#9288, @NSoiffer)
-* Commands to adjust the volume of other applications besides NVDA have been added.
-To use this feature, "allow NVDA to control the volume of other applications" must be enabled in the audio settings panel. (#16052, @mltony, @codeofdusk)
-  * `NVDA+alt+pageUp`: Increase the volume of all other applications.
-  * `NVDA+alt+pageDown`: Decrease the volume of all other applications.
-  * `NVDA+alt+delete`: Mute the volume of all other applications.
+* The ability to adjust the volume of other applications besides NVDA has been added.
+To use this feature, "allow NVDA to control the volume of other applications" must be enabled in the audio settings panel. (#16052, #17634, @mltony, @codeofdusk)
+  * Added new unassigned gestures to increase, decrease and mute the volume of all other applications.
 * When editing in Microsoft PowerPoint text boxes, you can now move per sentence with `alt+upArrow`/`alt+downArrow`. (#17015, @LeonarddeR)
 * In Mozilla Firefox, NVDA will report the highlighted text when a URL containing a text fragment is visited. (#16910, @jcsteh)
 * NVDA can now report when a link destination points to the current page. (#141, @LeonarddeR, @nvdaes)

user_docs/en/userGuide.md

@@ -2489,24 +2489,16 @@ While [audio ducking](#SelectSynthesizerDuckingMode) does change the volume of o
 ##### Volume of other applications {#OtherAppVolume}
 
 This slider allows you to adjust the volume of all currently running applications other than NVDA.
-This volume can also be controlled via the following keyboard commands from anywhere:
 
-| Name | Key | Description |
-|---|---|---|
-| Increase volume of other applications | `NVDA+alt+pageUp` | Increases the volume of all applications except NVDA. |
-| Decrease volume of other applications | `NVDA+alt+pageDown` | Decreases the volume of all applications except NVDA. |
+To increase or decrease the volume of all currently running applications from anywhere, please assign custom gestures using the [Input Gestures dialog](#InputGestures).
 
 ##### Mute other applications {#OtherAppMute}
 
 This check box allows you to mute or unmute all applications except NVDA at once.
 
-The following keyboard command can also be used from anywhere:
-
-| Name | Key | Description |
-|---|---|---|
-| Mute or unmute other applications | `NVDA+alt+delete` | Toggles mute/unmute on other applications |
+To mute or unmute all other applications from anywhere, please assign a custom gesture using the [Input Gestures dialog](#InputGestures).
 
-Please note, that this option is not persistent: other apps will always be unmuted when NVDA restarts.
+Please note that this option is not persistent: other apps will always be unmuted when NVDA restarts.
 
 ##### Time to keep audio device awake after speech {#AudioAwakeTime}