Code style: use c# 12 collection literals

Author: Romfos

.editorconfig

@@ -17,7 +17,9 @@ dotnet_style_qualification_for_field = false:suggestion
 dotnet_style_qualification_for_property = false:suggestion
 dotnet_style_qualification_for_method = false:suggestion
 dotnet_style_qualification_for_event = false:suggestion
-csharp_style_namespace_declarations=file_scoped:warning
+csharp_style_namespace_declarations = file_scoped:warning
+dotnet_style_prefer_collection_expression = true:warning
+dotnet_style_collection_initializer = true:warning
 
 # ReSharper properties
 resharper_int_align_switch_expressions = true

src/NSubstitute/Compatibility/DiagnosticsNullabilityAttributes.cs

@@ -90,7 +90,7 @@ internal sealed class MemberNotNullAttribute : Attribute
     /// <param name="member">
     /// The field or property member that is promised to be not-null.
     /// </param>
-    public MemberNotNullAttribute(string member) => Members = new[] { member };
+    public MemberNotNullAttribute(string member) => Members = [member];
 
     /// <summary>Initializes the attribute with the list of field and property members.</summary>
     /// <param name="members">
@@ -116,7 +116,7 @@ internal sealed class MemberNotNullWhenAttribute : Attribute
     public MemberNotNullWhenAttribute(bool returnValue, string member)
     {
         ReturnValue = returnValue;
-        Members = new[] { member };
+        Members = [member];
     }
 
     /// <summary>Initializes the attribute with the specified return value condition and list of field and property members.</summary>

src/NSubstitute/Core/ArgumentSpecificationDequeue.cs

@@ -5,7 +5,7 @@ namespace NSubstitute.Core;
 
 public class ArgumentSpecificationDequeue : IArgumentSpecificationDequeue
 {
-    private static readonly IArgumentSpecification[] EmptySpecifications = new IArgumentSpecification[0];
+    private static readonly IArgumentSpecification[] EmptySpecifications = [];
 
     private readonly Func<IList<IArgumentSpecification>> _dequeueAllQueuedArgSpecs;
 

src/NSubstitute/Core/Arguments/ArrayContentsArgumentMatcher.cs

@@ -31,7 +31,7 @@ public bool IsSatisfiedBy(object? argument)
 
     public string Format(object? argument, bool highlight)
     {
-        var argArray = argument is IEnumerable enumerableArgs ? enumerableArgs.Cast<object>().ToArray() : new object[0];
+        var argArray = argument is IEnumerable enumerableArgs ? enumerableArgs.Cast<object>().ToArray() : [];
         return Format(argArray, _argumentSpecifications).Join(", ");
     }
 

src/NSubstitute/Core/Call.cs

@@ -81,7 +81,7 @@ public void AssignSequenceNumber(long number)
         object?[] originalArray = _originalArguments;
         if (originalArray == _arguments && originalArray.Length > 0)
         {
-            object?[] copy = originalArray.ToArray();
+            object?[] copy = [.. originalArray];
             // If it happens that _originalArguments doesn't point to the `_arguments` anymore -
             // it might happen that other thread already created a copy and mutated the original `_arguments` array.
             // In this case it's unsafe to replace it with a copy.

src/NSubstitute/Core/CustomHandlers.cs

@@ -2,7 +2,7 @@
 
 public class CustomHandlers : ICustomHandlers
 {
-    private readonly List<ICallHandler> _handlers = new();
+    private readonly List<ICallHandler> _handlers = [];
     private readonly ISubstituteState _substituteState;
 
     public IReadOnlyCollection<ICallHandler> Handlers => _handlers;

src/NSubstitute/Core/DependencyInjection/NSubContainer.cs

@@ -17,7 +17,7 @@ public class NSubContainer : IConfigurableNSubContainer
 {
     private readonly NSubContainer? _parentContainer;
     private readonly object _syncRoot;
-    private readonly Dictionary<Type, Registration> _registrations = new();
+    private readonly Dictionary<Type, Registration> _registrations = [];
 
     public NSubContainer()
     {
@@ -177,7 +177,7 @@ public object Resolve(Scope scope)
 
     private class Scope : INSubResolver
     {
-        private readonly Dictionary<Registration, object> _cache = new Dictionary<Registration, object>();
+        private readonly Dictionary<Registration, object> _cache = [];
         private readonly NSubContainer _mostNestedContainer;
 
         public Scope(NSubContainer mostNestedContainer)

src/NSubstitute/Core/EventHandlerRegistry.cs

@@ -6,7 +6,7 @@ public class EventHandlerRegistry : IEventHandlerRegistry
     // Events are not expected to be configured/raised concurrently, so simple locking should be sufficient.
     // List lookup is O(n), but for really small size performance is comparable to dictionary.
     // Given that normally a few events are configured only, it should be totally fine.
-    private readonly List<Tuple<string, List<object>>> _handlersForEvent = new();
+    private readonly List<Tuple<string, List<object>>> _handlersForEvent = [];
 
     public void Add(string eventName, object handler)
     {

src/NSubstitute/Core/Events/DelegateEventWrapper.cs

@@ -64,7 +64,7 @@ private bool LooksLikeAnEventStyleCall(ParameterInfo[] parameters)
             sender = _providedArguments[0];
             eventArgs = GetDefaultForEventArgType(eventArgsType);
         }
-        return new[] { sender, eventArgs };
+        return [sender, eventArgs];
     }
 
     private static bool RequiredArgsHaveBeenProvided(object?[] providedArgs, ParameterInfo[] requiredArgs)

src/NSubstitute/Core/Events/EventHandlerWrapper.cs

@@ -35,6 +35,6 @@ protected override object[] WorkOutRequiredArguments(ICall call)
     {
         var sender = _sender ?? call.Target();
         var eventArgs = _eventArgs ?? GetDefaultForEventArgType(typeof(TEventArgs));
-        return new[] { sender, eventArgs };
+        return [sender, eventArgs];
     }
 }