Skip to content

Commit adcde73

Browse files
authored
Cleaned up (#129)
* Cleaned up * Fixing dependencies
1 parent 5b1094e commit adcde73

File tree

6 files changed

+292
-195
lines changed

6 files changed

+292
-195
lines changed

.github/workflows/node.js.yml

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -5,32 +5,31 @@ name: Node.js CI
55

66
on:
77
push:
8-
branches: [ main ]
8+
branches: [main]
99
pull_request:
10-
branches: [ main ]
10+
branches: [main]
1111

1212
jobs:
1313
build:
14-
1514
runs-on: ubuntu-latest
1615

1716
strategy:
1817
matrix:
19-
node-version: [16.x]
18+
node-version: [18.x]
2019
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2120

2221
steps:
23-
- uses: actions/checkout@v3
24-
- name: Use Node.js ${{ matrix.node-version }}
25-
uses: actions/setup-node@v3
26-
with:
27-
node-version: ${{ matrix.node-version }}
28-
cache: 'npm'
29-
- run: npm install
30-
- run: npm run check-format
31-
- run: npm run lint
32-
- run: npm run test
33-
- run: npm run test-simple-data
34-
- run: npm run test-simple-data-node
35-
- run: npm run test-simple-data-doc
36-
- run: npm run test-build
22+
- uses: actions/checkout@v3
23+
- name: Use Node.js ${{ matrix.node-version }}
24+
uses: actions/setup-node@v3
25+
with:
26+
node-version: ${{ matrix.node-version }}
27+
cache: "npm"
28+
- run: npm install
29+
- run: npm run check-format
30+
- run: npm run lint
31+
- run: npm run test
32+
- run: npm run test-simple-data
33+
- run: npm run test-simple-data-node
34+
- run: npm run test-simple-data-doc
35+
- run: npm run test-build

.mocharc.json

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
{
2-
"$schema": "https://json.schemastore.org/mocharc",
3-
"extension": ["ts"],
4-
"loader": "ts-node/esm",
5-
"spec": ["test"]
6-
}
2+
"$schema": "https://json.schemastore.org/mocharc",
3+
"extension": [
4+
"ts"
5+
],
6+
"loader": "ts-node/esm",
7+
"spec": [
8+
"test"
9+
]
10+
}

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,12 @@ As you can see below, SDA is a lightweight library optimized for the web (98kb
121121

122122
## Working with NodeJS and JavaScript Bundlers
123123

124-
First, make sure that your NodeJS version is 16 or higher. To check it, write ```node``` in your terminal and press Enter.
124+
First, make sure that your NodeJS version is 18 or higher. To check it, write ```node``` in your terminal and press Enter.
125125

126126
You should see something like this.
127127
<img src="./assets/nodeJSVersion.png" alt="A terminal showing the NodeJS version" style="display:block;width: 100%; max-width:400px;"/>
128128

129-
If the version is less than 16, update [NodeJS with the latest LTS (long-term support) version](https://nodejs.org/en/) .
129+
If the version is less than 18, update [NodeJS with the latest LTS (long-term support) version](https://nodejs.org/en/) .
130130

131131
To install the library with [npm](https://www.npmjs.com/package/simple-data-analysis), type this command in your terminal:
132132
```

assets/nodeJSVersion.png

102 KB
Loading

0 commit comments

Comments
 (0)