git: revert 44da664

It turns out that git commands do now log their output
appropriately, and this change was causing misleading output when using
`maybeGithub`, which was exposed by
89ce829, which fixed #7630. npm's git
functionality is maybe a little overcomplicated at this point.

Author: othiym23

lib/cache/maybe-github.js

@@ -1,19 +1,21 @@
-var assert = require("assert")
-  , log = require("npmlog")
-  , addRemoteGit = require("./add-remote-git.js")
-  , hosted = require("hosted-git-info")
+var assert = require('assert')
+
+var hosted = require('hosted-git-info')
+var log = require('npmlog')
+
+var addRemoteGit = require('./add-remote-git.js')
 
 module.exports = function maybeGithub (p, cb) {
-  assert(typeof p === "string", "must pass package name")
-  assert(typeof cb === "function", "must pass callback")
+  assert(typeof p === 'string', 'must pass package name')
+  assert(typeof cb === 'function', 'must pass callback')
 
   var parsed = hosted.fromUrl(p)
-  log.info("maybeGithub", "Attempting %s from %s", p, parsed.git())
+  log.info('maybeGithub', 'Attempting %s from %s', p, parsed.git())
 
   return addRemoteGit(parsed.git(), true, function (er, data) {
     if (er) {
-      log.info("maybeGithub", "Couldn't clone %s", parsed.git())
-      log.info("maybeGithub", "Now attempting %s from %s", p, parsed.sshurl())
+      log.info('maybeGithub', "Couldn't clone %s", parsed.git())
+      log.info('maybeGithub', 'Now attempting %s from %s', p, parsed.sshurl())
 
       return addRemoteGit(parsed.sshurl(), false, function (er, data) {
         if (er) return cb(er)

lib/utils/git.js

@@ -20,11 +20,7 @@ function prefixGitArgs () {
 function execGit (args, options, cb) {
   log.info('git', args)
   var fullArgs = prefixGitArgs().concat(args || [])
-  return exec(git, fullArgs, options, function (err) {
-    if (err) log.error('git', fullArgs.join(' '))
-
-    cb.apply(null, arguments)
-  })
+  return exec(git, fullArgs, options, cb)
 }
 
 function spawnGit (args, options) {