Skip to content

Commit 76b02e8

Browse files
authored
feat: use @npmcli/redact for url cleaning (#231)
1 parent e58e8bc commit 76b02e8

File tree

4 files changed

+6
-29
lines changed

4 files changed

+6
-29
lines changed

lib/check-response.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const errors = require('./errors.js')
44
const { Response } = require('minipass-fetch')
55
const defaultOpts = require('./default-opts.js')
66
const log = require('proc-log')
7-
const cleanUrl = require('./clean-url.js')
7+
const { redact: cleanUrl } = require('@npmcli/redact')
88

99
/* eslint-disable-next-line max-len */
1010
const moreInfoUrl = 'https://github.com/npm/cli/wiki/No-auth-for-URI,-but-auth-present-for-scoped-registry'

lib/clean-url.js

Lines changed: 0 additions & 27 deletions
This file was deleted.

lib/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ const qs = require('querystring')
1010
const url = require('url')
1111
const zlib = require('minizlib')
1212
const { Minipass } = require('minipass')
13+
const { redact: cleanUrl } = require('@npmcli/redact')
1314

1415
const defaultOpts = require('./default-opts.js')
1516

@@ -246,4 +247,6 @@ function getHeaders (uri, auth, opts) {
246247
return headers
247248
}
248249

249-
module.exports.cleanUrl = require('./clean-url.js')
250+
// export cleanUrl to avoid a breaking change
251+
// TODO: next semver major remove this. Consumers should use @npmcli/redact instead
252+
module.exports.cleanUrl = cleanUrl

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"author": "GitHub Inc.",
3232
"license": "ISC",
3333
"dependencies": {
34+
"@npmcli/redact": "^1.1.0",
3435
"make-fetch-happen": "^13.0.0",
3536
"minipass": "^7.0.2",
3637
"minipass-fetch": "^3.0.0",

0 commit comments

Comments
 (0)