Fix --dev deprecation message #1575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
approved these changes
Aug 17, 2020
Contributor
ruyadorno
left a comment
ruyadorno
left a comment
There was a problem hiding this comment.
awesome finding! 🤩 thank you so much!
ruyadorno
added
Release 6.x
ruyadorno
pushed a commit
that referenced
this pull request
Aug 17, 2020
- also fix: add npm ci --dev deprecation message - Related to #1539 PR-URL: #1575 Credit: @sandratatarevicova Close: #1575 Reviewed-by: @ruyadorno
ruyadorno
pushed a commit
that referenced
this pull request
Aug 17, 2020
- also fix: add npm ci --dev deprecation message - Related to #1539 PR-URL: #1575 Credit: @sandratatarevicova Close: #1575 Reviewed-by: @ruyadorno
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
--devoption withnpm install, the command prints this deprecation message:The
--onlyoption was added within npm/npm#9024 and with--only=dev, onlydevDependenciesare installed. This PR also introduced the--alsooption which can install bothdependenciesanddevDependencies. I have checked thatnpm install --devinstalls bothdependenciesanddevDependencies(see https://github.com/npm/cli/blob/latest/lib/install.js#L233), so I think that the correct message should be:I have added the deprecation message also to
npm ci --dev. If this PR is approved I will add the--alsooption to npm install documentation.References