Skip to content

Commit f9d18b3

Browse files
authored
remove websocket experimental warning (#3311)
* remove websocket experimental warning * ?? * fixup
1 parent c36c3e8 commit f9d18b3

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

lib/web/websocket/websocket.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ const { types } = require('node:util')
2828
const { ErrorEvent, CloseEvent } = require('./events')
2929
const { SendQueue } = require('./sender')
3030

31-
let experimentalWarned = false
32-
3331
// https://websockets.spec.whatwg.org/#interface-definition
3432
class WebSocket extends EventTarget {
3533
#events = {
@@ -56,13 +54,6 @@ class WebSocket extends EventTarget {
5654
const prefix = 'WebSocket constructor'
5755
webidl.argumentLengthCheck(arguments, 1, prefix)
5856

59-
if (!experimentalWarned) {
60-
experimentalWarned = true
61-
process.emitWarning('WebSockets are experimental, expect them to change at any time.', {
62-
code: 'UNDICI-WS'
63-
})
64-
}
65-
6657
const options = webidl.converters['DOMString or sequence<DOMString> or WebSocketInit'](protocols, prefix, 'options')
6758

6859
url = webidl.converters.USVString(url, prefix, 'url')

test/node-test/debug.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const { tspl } = require('@matteo.collina/tspl')
99
const removeEscapeColorsRE = /[\u001b\u009b][[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><]/g
1010

1111
test('debug#websocket', { skip: !process.versions.icu }, async t => {
12-
const assert = tspl(t, { plan: 8 })
12+
const assert = tspl(t, { plan: 6 })
1313
const child = spawn(
1414
process.execPath,
1515
[join(__dirname, '../fixtures/websocket.js')],
@@ -22,9 +22,6 @@ test('debug#websocket', { skip: !process.versions.icu }, async t => {
2222
const chunks = []
2323
const assertions = [
2424
/(WEBSOCKET [0-9]+:) (connecting to)/,
25-
// Skip the chunk that comes with the experimental warning
26-
/(\[UNDICI-WS\])/,
27-
/\(Use `node --trace-warnings \.\.\.` to show where the warning was created\)/,
2825
/(WEBSOCKET [0-9]+:) (connected to)/,
2926
/(WEBSOCKET [0-9]+:) (sending request)/,
3027
/(WEBSOCKET [0-9]+:) (connection opened)/,

0 commit comments

Comments
 (0)