Skip to content

Commit ba300bf

Browse files
committed
avoid after
1 parent c45450c commit ba300bf

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

test/fetch/encoding.js

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
const { once } = require('node:events')
44
const { createServer } = require('node:http')
5-
const { test, after } = require('node:test')
6-
const zlib = require('node:zlib')
5+
const { test } = require('node:test')
76
const { tspl } = require('@matteo.collina/tspl')
87
const { fetch } = require('../..')
98

@@ -14,7 +13,7 @@ test('content-encoding header', async (t) => {
1413
const text = 'Hello, World!'
1514
const gzipDeflateText = Buffer.from('H4sIAAAAAAAAA6uY89nj7MmT1wM5zuuf8gxkYZCfx5IFACQ8u/wVAAAA', 'base64')
1615

17-
const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
16+
const server = createServer((req, res) => {
1817
res.writeHead(200,
1918
{
2019
'Content-Encoding': contentEncoding,
@@ -23,8 +22,6 @@ test('content-encoding header', async (t) => {
2322
)
2423
.end(gzipDeflateText)
2524
})
26-
after(() => server.close())
27-
2825
await once(server.listen(0), 'listening')
2926

3027
const response = await fetch(`http://localhost:${server.address().port}`)
@@ -33,6 +30,7 @@ test('content-encoding header', async (t) => {
3330
strictEqual(await response.text(), text)
3431

3532
await t.completed
33+
server.close()
3634
})
3735

3836
test('content-encoding header is case-iNsENsITIve', async (t) => {
@@ -42,7 +40,7 @@ test('content-encoding header is case-iNsENsITIve', async (t) => {
4240
const text = 'Hello, World!'
4341
const gzipDeflateText = Buffer.from('H4sIAAAAAAAAA6uY89nj7MmT1wM5zuuf8gxkYZCfx5IFACQ8u/wVAAAA', 'base64')
4442

45-
const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
43+
const server = createServer((req, res) => {
4644
res.writeHead(200,
4745
{
4846
'Content-Encoding': contentEncoding,
@@ -51,7 +49,6 @@ test('content-encoding header is case-iNsENsITIve', async (t) => {
5149
)
5250
.end(gzipDeflateText)
5351
})
54-
after(() => server.close())
5552

5653
await once(server.listen(0), 'listening')
5754

@@ -61,26 +58,26 @@ test('content-encoding header is case-iNsENsITIve', async (t) => {
6158
strictEqual(await response.text(), text)
6259

6360
await t.completed
61+
server.close()
6462
})
6563

6664
test('should decompress zstandard response',
67-
{ skip: typeof zlib.createZstdDecompress !== 'function' },
65+
{ skip: typeof require('node:zlib').createZstdDecompress !== 'function' },
6866
async (t) => {
6967
const { strictEqual } = tspl(t, { plan: 3 })
7068

7169
const contentEncoding = 'zstd'
7270
const text = 'Hello, World!'
7371
const zstdText = Buffer.from('KLUv/QBYaQAASGVsbG8sIFdvcmxkIQ==', 'base64')
7472

75-
const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
73+
const server = createServer((req, res) => {
7674
res.writeHead(200,
7775
{
7876
'Content-Encoding': contentEncoding,
7977
'Content-Type': 'text/plain'
8078
})
8179
.end(zstdText)
8280
})
83-
after(() => server.close())
8481

8582
await once(server.listen(0), 'listening')
8683

@@ -92,4 +89,5 @@ test('should decompress zstandard response',
9289
strictEqual(response.headers.get('content-type'), 'text/plain')
9390

9491
await t.completed
92+
server.close()
9593
})

0 commit comments

Comments
 (0)