fix writing to websocketstream with SharedArrayBuffer/SharedArrayBuffer view (#4504)

Author: KhafraDev

lib/web/websocket/stream/websocketstream.js

@@ -199,6 +199,9 @@ class WebSocketStream {
   }
 
   #write (chunk) {
+    // See /websockets/stream/tentative/write.any.html
+    chunk = webidl.converters.WebSocketStreamWrite(chunk)
+
     // 1. Let promise be a new promise created in stream ’s relevant realm .
     const promise = createDeferredPromise()
 
@@ -484,4 +487,12 @@ webidl.converters.WebSocketCloseInfo = webidl.dictionaryConverter([
   }
 ])
 
+webidl.converters.WebSocketStreamWrite = function (V) {
+  if (typeof V === 'string') {
+    return webidl.converters.USVString(V)
+  }
+
+  return webidl.converters.BufferSource(V)
+}
+
 module.exports = { WebSocketStream }

test/web-platform-tests/expectation.json

@@ -39837,13 +39837,11 @@
             },
             {
               "name": "writing a resizable ArrayBuffer should be rejected",
-              "success": false,
-              "message": "assert_unreached: Should have rejected: write() should reject Reached unreachable code"
+              "success": true
             },
             {
               "name": "writing a view on a shared buffer should be rejected",
-              "success": false,
-              "message": "promise_rejects_js: write() should reject function \"function() { throw e; }\" threw object \"RangeError: Invalid string length\" (\"RangeError\") expected instance of function \"function TypeError() { [native code] }\" (\"TypeError\")"
+              "success": true
             },
             {
               "name": "Garbage collecting a WebSocket stream doesn't crash while write promise is pending",

types/webidl.d.ts

@@ -247,6 +247,8 @@ interface WebidlConverters {
    */
   EventHandlerNonNull (V: unknown): Function | null
 
+  WebSocketStreamWrite (V: unknown): ArrayBuffer | NodeJS.TypedArray | string
+
   [Key: string]: (...args: any[]) => unknown
 }