Update tap13 from upstream, reapply py3 compat again #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@nodejs/python could we get some python people reviews please? Also if you could watch this repo and help out on reviewing PRs and with discussions that would be great. I promise it'll be extremely infrequent, it's just getting up to speed having just moved into the org. |
sam-github
approved these changes
Oct 28, 2019
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
Licensing looks good, no comment on the python code.
63 tasks
cjihrig
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18, nodejs/admin#413
Update tap13.py to latest (Apache licensed)
Pulled latest from upstream:
Note that upstream version is now under the Apache License 2.0.