fix for sync write issues in older node

Author: calvinmetcalf

build/files.js

@@ -128,7 +128,12 @@ const headRegexp = /(^module.exports = \w+;?)/m
 
     , processNextTickImport = [
       headRegexp
-    , '$1\n\n/*<replacement>*/\nvar processNextTick = require(\'process-nextick-args\');\n/*</replacement>*/\n'
+    , `$1
+
+/*<replacement>*/
+  var processNextTick = require(\'process-nextick-args\');
+/*</replacement>*/
+`
     ]
 
     , processNextTickReplacement = [
@@ -140,7 +145,30 @@ const headRegexp = /(^module.exports = \w+;?)/m
           /^const internalUtil = require\('internal\/util'\);/m
         ,   '\n/*<replacement>*/\nconst internalUtil = {\n  deprecate: require(\'util-deprecate\')\n};\n'
           + '/*</replacement>*/\n'
+      ],
+      isNode10 = [
+        headRegexp
+      , `$1
+
+/*<replacement>*/
+  var isNode10 = !process.browser && ['v0.10' , 'v0.9.'].indexOf(process.version.slice(0, 5)) > -1;
+/*</replacement>*/
+`
       ]
+    , fixSyncWrite = [
+      /if \(sync\) {\n\s+processNextTick\(afterWrite, stream, state, finished, cb\);\n\s+}/
+      , `if (sync) {
+      /*<replacement>*/
+      if (isNode10) {
+        setTimeout(afterWrite, 0, stream, state, finished, cb);
+      } else {
+        processNextTick(afterWrite, stream, state, finished, cb);
+      }
+      /*</replacement>*/
+    }
+
+      `
+    ]
 
 module.exports['_stream_duplex.js'] = [
     requireReplacement
@@ -211,5 +239,7 @@ module.exports['_stream_writable.js'] = [
   , processNextTickImport
   , processNextTickReplacement
   , internalUtilReplacement
+  , isNode10
+  , fixSyncWrite
 
 ]

lib/_stream_writable.js

@@ -6,6 +6,10 @@
 
 module.exports = Writable;
 
+/*<replacement>*/
+var isNode10 = !process.browser && ['v0.10', 'v0.9.'].indexOf(process.version.slice(0, 5)) > -1;
+/*</replacement>*/
+
 /*<replacement>*/
 var processNextTick = require('process-nextick-args');
 /*</replacement>*/
@@ -341,10 +345,16 @@ function onwrite(stream, er) {
     }
 
     if (sync) {
-      processNextTick(afterWrite, stream, state, finished, cb);
+      /*<replacement>*/
+      if (isNode10) {
+        setTimeout(afterWrite, 0, stream, state, finished, cb);
+      } else {
+        processNextTick(afterWrite, stream, state, finished, cb);
+      }
+      /*</replacement>*/
     } else {
-      afterWrite(stream, state, finished, cb);
-    }
+        afterWrite(stream, state, finished, cb);
+      }
   }
 }
 

package.json

@@ -17,7 +17,7 @@
     "zuul": "~3.9.0"
   },
   "scripts": {
-    "test": "tap test/parallel/*.js",
+    "test": "tap test/parallel/*.js test/ours/*.js",
     "browser": "npm run write-zuul && zuul -- test/browser.js",
     "write-zuul": "printf \"ui: tape\nbrowsers:\n  - name: $BROWSER_NAME\n    version: $BROWSER_VERSION\n\">.zuul.yml"
   },

test/browser.js

@@ -36,6 +36,7 @@ test('streams', function (t) {
   require('./browser/test-stream-writable-constructor-set-methods')(t);
   require('./browser/test-stream-writable-decoded-encoding')(t);
   require('./browser/test-stream-writev')(t);
+  require('./browser/test-stream-sync-write')(t);
   require('./browser/test-stream-pipe-without-listenerCount');
 });
 

test/browser/test-stream-sync-write.js

@@ -0,0 +1,39 @@
+require('../common');
+var inherits = require('inherits');
+var stream = require('../../');
+var WritableStream = stream.Writable;
+module.exports = function(t) {
+  t.test('should bea ble to write sync', function(t) {
+    var InternalStream = function() {
+      WritableStream.call(this);
+    };
+    inherits(InternalStream, WritableStream);
+
+    InternalStream.prototype._write = function(chunk, encoding, callback) {
+      callback();
+    };
+
+    var internalStream = new InternalStream();
+
+
+
+    var ExternalStream = function(writable) {
+      this._writable = writable;
+      WritableStream.call(this);
+    };
+    inherits(ExternalStream, WritableStream);
+
+    ExternalStream.prototype._write = function(chunk, encoding, callback) {
+      this._writable.write(chunk, encoding, callback);
+    };
+
+
+
+    var externalStream = new ExternalStream(internalStream);
+
+    for (var i = 0; i < 2000; i++) {
+      externalStream.write(i.toString());
+    }
+    t.end();
+  });
+}

test/ours/test-stream-sync-write.js

@@ -0,0 +1,36 @@
+require('../common');
+var util = require('util');
+var stream = require('../../');
+var WritableStream = stream.Writable;
+
+
+var InternalStream = function() {
+    WritableStream.call(this);
+};
+util.inherits(InternalStream, WritableStream);
+
+InternalStream.prototype._write = function(chunk, encoding, callback) {
+    callback();
+};
+
+var internalStream = new InternalStream();
+
+
+
+var ExternalStream = function(writable) {
+    this._writable = writable;
+    WritableStream.call(this);
+};
+util.inherits(ExternalStream, WritableStream);
+
+ExternalStream.prototype._write = function(chunk, encoding, callback) {
+    this._writable.write(chunk, encoding, callback);
+};
+
+
+
+var externalStream = new ExternalStream(internalStream);
+
+for (var i = 0; i < 2000; i++) {
+    externalStream.write(i.toString());
+}