This repository was archived by the owner on Aug 11, 2020. It is now read-only.
quic: cleanups and use backing store for statsbase #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
addaleax
approved these changes
Apr 11, 2020
jasnell
force-pushed
the
misc-cleanups-and-backing-store
branch
from
bb422b8 to
5cee239
Compare
Contributor
danbev
approved these changes
Apr 16, 2020
Member
Author
|
No worries at all @danbev ... will rebase before landing. |
jasnell
force-pushed
the
misc-cleanups-and-backing-store
branch
from
d8616d7 to
4eaf34e
Compare
Member
Author
|
Landed |
jasnell
added a commit
that referenced
this pull request
Apr 18, 2020
PR-URL: #366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
jasnell
added a commit
that referenced
this pull request
Apr 18, 2020
PR-URL: #366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
jasnell
added a commit
that referenced
this pull request
Apr 18, 2020
PR-URL: #366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
jasnell
added a commit
that referenced
this pull request
Apr 18, 2020
PR-URL: #366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
PR-URL: nodejs#366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
PR-URL: nodejs#366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
PR-URL: nodejs#366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
PR-URL: nodejs#366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
PR-URL: nodejs#366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
PR-URL: nodejs#366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
PR-URL: nodejs#366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
PR-URL: nodejs#366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here:
The first makes a number of style cleanups.
The second updates StatsBase to use a BackingStore instead of the aliased buffer. If nodejs/node#32778 lands, it will be updated to use the
AliasedStructadded there.