attempt to use arm as default for mac

[bmuenzenmeyer]

Description

Set default mac architecture to arm64

Validation

hard to verify as I learned I cannot run the site at all on my work network (a me problem!)

Related Issues

attempt to address #8324

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run pnpm format to ensure the code follows the style guide.
• I have run pnpm test to check if all tests are passing.
• I have run pnpm build to check if the website builds without errors.
• I've covered new added functionality with unit tests if necessary.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
nodejs-org	Ready	Preview	Nov 5, 2025 5:03pm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (9fbb9f6) to head (5147f1a).
⚠️ Report is 16 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8328   +/-   ##
=======================================
  Coverage   76.72%   76.73%           
=======================================
  Files         118      118           
  Lines        9805     9808    +3     
  Branches      335      336    +1     
=======================================
+ Hits         7523     7526    +3     
  Misses       2280     2280           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AugustinMauroy]

Why not

[Copilot]

Pull Request Overview

This PR updates the OS detection logic to default to ARM architecture for macOS devices when high entropy values are unavailable. The change reflects the shift in Apple's hardware from Intel (x86) to Apple Silicon (ARM) processors.

• Extracts the detectOS() call into a variable to avoid calling it twice
• Updates the fallback architecture logic to assume ARM for macOS and x86 for other operating systems
• Updates the corresponding test to expect the new default ARM architecture for macOS

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
apps/site/hooks/react-client/useDetectOS.ts	Extracts OS detection to a variable and changes macOS fallback architecture to ARM
apps/site/hooks/react-client/tests/useDetectOS.test.mjs	Updates test assertion to expect ARM architecture for macOS

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ovflowd]

The code was wrong, there was a bug. I've fixed it.

[efekrskl]

Seems to work fine now (I'm on M1)

[ljharb]

is there a preview link i can use to verify whether this works or not?

[ovflowd]

is there a preview link i can use to verify whether this works or not?

#8328 (comment)

[ljharb]

Thanks, I didn't see it in the status check section and missed the comment. It certainly defaults to ARM64 for me in Safari on my M4.

[ovflowd]

Thanks, I didn't see it in the status check section and missed the comment. It certainly defaults to ARM64 for me in Safari on my M4.

No worries! It's easy T times to get lost on the sea of comments. For future reference, PRs here the Vercel deployment often is the first comment of any PR.

[avivkeller]

@bmuenzenmeyer can you resolve open convos so we can merge this?

[bmuenzenmeyer]

Can look later today. Thanks for ping!